Skip to content

feat: AttachmentBadge, disabled AttachmentPreview, and export scrollFade - #10594

Open
DPandyan wants to merge 3 commits into
mainfrom
attachment-badge
Open

DPandyan wants to merge 3 commits into
mainfrom
attachment-badge

Conversation

@DPandyan

@DPandyan DPandyan commented Sep 10, 2026

Copy link
Copy Markdown
Collaborator

Closes RSP Component Milestones (view)

Adds AttachmentBadge, a disabled state for AttachmentPreview and exports the scroll macro. I included them all in the same PR because disabled + AttachmentBadge may need some attention. I can separate them if need be.

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices
  • I understand every change in this PR and can explain why it's there.
  • If AI-assisted, I followed our AI contribution guidance and pointed my assistant at CLAUDE.md.

📝 Test Instructions:

Open AttachmentList component story, toggle on the large size. The badge should be visible. Also play with the alert and disabled variants.

Finally confirm that scrollFade still works with AttachmentList, when AttachmentGrid is merged in that will likely need a check as well.

🧢 Your Project:

Adobe

@DPandyan DPandyan changed the title add: AttachmentBadge for large thumnail AttachmentList variant feat: AttachmentBadge for large thumnail AttachmentList variant Sep 10, 2026
@rspbot

rspbot commented Sep 10, 2026

Copy link
Copy Markdown

@DPandyan DPandyan changed the title feat: AttachmentBadge for large thumnail AttachmentList variant feat: AttachmentBadge for large thumbnail AttachmentList variant Sep 10, 2026
@DPandyan DPandyan changed the title feat: AttachmentBadge for large thumbnail AttachmentList variant feat: AttachmentBadge, disabled AttachmentPreview, and export scrollFade Sep 14, 2026
@DPandyan
DPandyan marked this pull request as ready for review September 14, 2026 18:48
@rspbot

rspbot commented Sep 14, 2026

Copy link
Copy Markdown

@rspbot

rspbot commented Sep 14, 2026

Copy link
Copy Markdown
## API Changes

@react-spectrum/ai

/@react-spectrum/ai:AttachmentPreview

 AttachmentPreview {
   UNSAFE_className?: UnsafeClassName
   UNSAFE_style?: CSSProperties
   alt?: string
   crossOrigin?: 'anonymous' | 'use-credentials'
   decoding?: 'async' | 'auto' | 'sync'
   fetchPriority?: 'high' | 'low' | 'auto'
   group?: ImageGroup
   height?: number
   itemProp?: string
   loading?: 'eager' | 'lazy'
-  mimeType: string
+  mimeType?: string
   referrerPolicy?: HTMLAttributeReferrerPolicy
   renderError?: () => ReactNode
   slot?: string | null
   src?: string | Array<ImageSource>
   width?: number
 }

/@react-spectrum/ai:AttachmentPreviewProps

 AttachmentPreviewProps {
   UNSAFE_className?: UnsafeClassName
   UNSAFE_style?: CSSProperties
   alt?: string
   crossOrigin?: 'anonymous' | 'use-credentials'
   decoding?: 'async' | 'auto' | 'sync'
   fetchPriority?: 'high' | 'low' | 'auto'
   group?: ImageGroup
   height?: number
   itemProp?: string
   loading?: 'eager' | 'lazy'
-  mimeType: string
+  mimeType?: string
   referrerPolicy?: HTMLAttributeReferrerPolicy
   renderError?: () => ReactNode
   slot?: string | null
   src?: string | Array<ImageSource>
   width?: number
 }

@rspbot

rspbot commented Sep 14, 2026

Copy link
Copy Markdown

Agent Skills Changes

Modified (9)
Install

React Spectrum S2:

npx skills add https://d1pzu54gtk2aed.cloudfront.net/pr/cd6aac45e2db807fccfff029c10ef2106184dc8c/

React Aria:

npx skills add https://d5iwopk28bdhl.cloudfront.net/pr/cd6aac45e2db807fccfff029c10ef2106184dc8c/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants