docs: Document shouldObserveItemSize - #10392
Open
snowystinger wants to merge 2 commits into
Open
Conversation
snowystinger
commented
Jul 29, 2026
|
Build successful! 🎉 |
|
Build successful! 🎉 |
Agent Skills ChangesModified (4)
InstallReact Spectrum S2: React Aria: |
devongovett
reviewed
Jul 30, 2026
| return ( | ||
| <div className="expandable-item"> | ||
| <Text>{item.name}</Text> | ||
| <Button onPress={() => setExpanded(!expanded)} aria-label={expanded ? 'Collapse' : 'Expand'}> |
Member
There was a problem hiding this comment.
these repeated primary buttons are kind of a lot. maybe variant=quiet would be better?
|
|
||
| <ExampleList tag="virtualizer" pages={props.pages} /> | ||
|
|
||
| ## Items that change size |
Member
There was a problem hiding this comment.
Move above Examples (Examples is always the last section before API).
Maybe re-title to "Dynamic item sizes"?
Comment on lines
+730
to
+731
| When using a `Virtualizer` with content that can change size, you can tell the `Virtualizer` to observe | ||
| the items so that it updates the layout accordingly. This is done by setting the `shouldObserveItemSize` prop. |
Member
There was a problem hiding this comment.
Suggested change
| When using a `Virtualizer` with content that can change size, you can tell the `Virtualizer` to observe | |
| the items so that it updates the layout accordingly. This is done by setting the `shouldObserveItemSize` prop. | |
| Use the `shouldObserveItemSize` prop to automatically re-layout when items change size. Note that this uses a `ResizeObserver` internally and may have performance overhead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: