fix: SideNav selectedRoute optional - #10391
Merged
Merged
Conversation
|
Build successful! 🎉 |
|
Build successful! 🎉 |
## API Changes
@react-spectrum/s2/@react-spectrum/s2:SideNav SideNav <T> {
UNSAFE_className?: UnsafeClassName
UNSAFE_style?: CSSProperties
aria-describedby?: string
aria-details?: string
aria-label?: string
aria-labelledby?: string
autoFocus?: boolean | FocusStrategy
children?: ReactNode | (T) => ReactNode
defaultExpandedKeys?: Iterable<Key>
dependencies?: ReadonlyArray<any>
disabledKeys?: Iterable<Key>
expandedKeys?: Iterable<Key>
id?: string
items?: Iterable<T>
onExpandedChange?: (Set<Key>) => any
- selectedRoute: string
+ selectedRoute?: string | null
slot?: string | null
styles?: StylesPropWithHeight
}/@react-spectrum/s2:SideNavProps SideNavProps <T> {
UNSAFE_className?: UnsafeClassName
UNSAFE_style?: CSSProperties
aria-describedby?: string
aria-details?: string
aria-label?: string
aria-labelledby?: string
autoFocus?: boolean | FocusStrategy
children?: ReactNode | (T) => ReactNode
defaultExpandedKeys?: Iterable<Key>
dependencies?: ReadonlyArray<any>
disabledKeys?: Iterable<Key>
expandedKeys?: Iterable<Key>
id?: string
items?: Iterable<T>
onExpandedChange?: (Set<Key>) => any
- selectedRoute: string
+ selectedRoute?: string | null
slot?: string | null
styles?: StylesPropWithHeight
} |
Agent Skills ChangesModified (3)
InstallReact Spectrum S2: React Aria: |
LFDanLu
approved these changes
Jul 29, 2026
devongovett
approved these changes
Jul 30, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes
Found while working on putting SideNav in our docs, we have pages like
useButtonwhich don't have a link in our SideNav but do display the SideNav when you visit those pages throughButton's ToC or through search.✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: