Skip to content

fix: #7372 Trigger onAction on Space key when selectionMode is none - #10386

Open
jsmitrah wants to merge 2 commits into
adobe:mainfrom
jsmitrah:fix/7372/tree-space-onAction-selection-none
Open

fix: #7372 Trigger onAction on Space key when selectionMode is none#10386
jsmitrah wants to merge 2 commits into
adobe:mainfrom
jsmitrah:fix/7372/tree-space-onAction-selection-none

Conversation

@jsmitrah

Copy link
Copy Markdown

Closes #7372

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

  • Set selectionMode="none" on the Tree and focus a tree item.
  • Press Space and verify onAction triggers (or the node expands) instead of doing nothing.

🧢 Your Project:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

If selectionMode="none" is set on a Tree, space should trigger onAction (currently only enter will trigger onAction

1 participant