fix: ResponseStatus QA - #10384
Conversation
…oesn't impact the height transition
|
Build successful! 🎉 |
|
Build successful! 🎉 |
snowystinger
left a comment
There was a problem hiding this comment.
Not sure what happened to the spacing between items? was that intentional?
Should all the content of the top level response status be only 2px in from the outside, it either doesn't look like enough to visually separate, or just ever so slightly off if it's supposed to align. It looks like the values match Disclosure, so I'm betting it's an issue with the padding on the ol, maybe reduce it from 4 to 2?
| } | ||
|
|
||
| const detailTriggerStyles = style({ | ||
| display: 'block', |
There was a problem hiding this comment.
Is this correct? It looks like the child has CenterBaseline for an icon, so this should be display flex already.
Then I think we can remove the marginStart from detailTriggerChevronStyles
|
|
||
| const executionTraceDisclosureContainerStyles = style({ | ||
| paddingBottom: 12, | ||
| marginTop: -4 |
There was a problem hiding this comment.
I think we could get rid of this negative margin if we changed the item to display as a grid
template areas
[['icon', 'button'],
['line', 'content']]
then we could center baseline the icon vertically in it's cell, which would be the same height as the text, even if the text were to wrap (don't know if that's a thing)
the line would just have stretch set
I think this would also help with eventual changes to font size or tshirt size
✨ Changes:
📝 Test Instructions:
ExecutionTraceItemsResponseStatusand childExecutionTraceItems and see focus ring hug content