Skip to content

fix: ResponseStatus QA - #10384

Draft
catherine wants to merge 4 commits into
mainfrom
b/response_status_qa
Draft

fix: ResponseStatus QA#10384
catherine wants to merge 4 commits into
mainfrom
b/response_status_qa

Conversation

@catherine

@catherine catherine commented Jul 29, 2026

Copy link
Copy Markdown
Collaborator

✨ Changes:

  • fix: move paddingBottom from disclosure panel to wrapper so that it doesn't impact the height transition
  • fix: don't stretch disclosure so that focus ring hugs content

📝 Test Instructions:

  • content jump flicker no longer happening when expanding/collapsing ExecutionTraceItems
  • tab to parent ResponseStatus and child ExecutionTraceItems and see focus ring hug content

@rspbot

rspbot commented Jul 29, 2026

Copy link
Copy Markdown

@rspbot

rspbot commented Jul 29, 2026

Copy link
Copy Markdown

@rspbot

rspbot commented Jul 29, 2026

Copy link
Copy Markdown

Agent Skills Changes

Removed (6)
  • react-aria/skills/react-aria/references/utilities/useAsyncList.md
  • react-aria/skills/react-aria/references/utilities/useListData.md
  • react-aria/skills/react-aria/references/utilities/useTreeData.md
  • s2/skills/react-spectrum-s2/references/react-aria/utilities/useAsyncList.md
  • s2/skills/react-spectrum-s2/references/react-aria/utilities/useListData.md
  • s2/skills/react-spectrum-s2/references/react-aria/utilities/useTreeData.md
Modified (17)
Install

React Spectrum S2:

npx skills add https://d1pzu54gtk2aed.cloudfront.net/pr/ec6f7b1975103728e63a1e25879fb31dea497929/

React Aria:

npx skills add https://d5iwopk28bdhl.cloudfront.net/pr/ec6f7b1975103728e63a1e25879fb31dea497929/

@snowystinger snowystinger left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what happened to the spacing between items? was that intentional?

Image

Should all the content of the top level response status be only 2px in from the outside, it either doesn't look like enough to visually separate, or just ever so slightly off if it's supposed to align. It looks like the values match Disclosure, so I'm betting it's an issue with the padding on the ol, maybe reduce it from 4 to 2?

Image

}

const detailTriggerStyles = style({
display: 'block',

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this correct? It looks like the child has CenterBaseline for an icon, so this should be display flex already.
Then I think we can remove the marginStart from detailTriggerChevronStyles


const executionTraceDisclosureContainerStyles = style({
paddingBottom: 12,
marginTop: -4

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we could get rid of this negative margin if we changed the item to display as a grid

template areas
[['icon', 'button'],
 ['line', 'content']]

then we could center baseline the icon vertically in it's cell, which would be the same height as the text, even if the text were to wrap (don't know if that's a thing)

the line would just have stretch set

I think this would also help with eventual changes to font size or tshirt size

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants