Skip to content

fix: speed up and fix v-publish-stats #10185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
snowystinger wants to merge 2 commits into
base: main
Choose a base branch
from
+31 −16
Open

fix: speed up and fix v-publish-stats #10185

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
57f9a78
fix: speed up and fix v-publish-stats
snowystinger Jun 11, 2026
4ae77f4
fix formatting
snowystinger Jun 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 31 additions & 16 deletions scripts/compareSize.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,23 +26,24 @@ async function compareBuildAppSize() {
let lastPublishStatUrl = `https://reactspectrum.blob.core.windows.net/reactspectrum/${commit}/verdaccio/rsp-cra-18/publish-stats/${currentPublishStatsFile}`;
let lastAppStatPath = path.join(__dirname, '..', lastAppStatsFile);
let lastPublishStatPath = path.join(__dirname, '..', lastPublishStatsFile);
await download(lastAppStatUrl, lastAppStatPath);
await download(lastPublishStatUrl, lastPublishStatPath);
await Promise.all([
download(lastAppStatUrl, lastAppStatPath),
download(lastPublishStatUrl, lastPublishStatPath)
]);

if (!fs.existsSync(lastAppStatPath)) {
// TODO: placeholder until we get some real stats. Hardcoded URL pointing to a commit with actual data
await download(
`https://reactspectrum.blob.core.windows.net/reactspectrum/2504f8ad927d0d0ad55e7e6db8a22fec16a67b6f/verdaccio/publish-stats/${currentAppStatsFile}`,
lastAppStatPath
);
}

if (!fs.existsSync(lastPublishStatPath)) {
await download(
`https://reactspectrum.blob.core.windows.net/reactspectrum/2504f8ad927d0d0ad55e7e6db8a22fec16a67b6f/verdaccio/publish-stats/${currentPublishStatsFile}`,
lastPublishStatPath
);
}
await Promise.all([
!fs.existsSync(lastAppStatPath) &&
download(
// TODO: placeholder until we get some real stats. Hardcoded URL pointing to a commit with actual data
`https://reactspectrum.blob.core.windows.net/reactspectrum/2504f8ad927d0d0ad55e7e6db8a22fec16a67b6f/verdaccio/publish-stats/${currentAppStatsFile}`,
lastAppStatPath
),
!fs.existsSync(lastPublishStatPath) &&
download(
`https://reactspectrum.blob.core.windows.net/reactspectrum/2504f8ad927d0d0ad55e7e6db8a22fec16a67b6f/verdaccio/publish-stats/${currentPublishStatsFile}`,
lastPublishStatPath
)
]);

// Extract the built example app size from the current commit and the last publish commit data
let lastAppStats = fs.readFileSync(lastAppStatsFile, 'utf8');
Expand Down Expand Up @@ -109,13 +110,27 @@ function download(url, dest) {
});
}
});
response.on('error', err => {
file.close();
fs.unlink(dest, () => {
console.error(err);
resolve();
});
});
response.pipe(file);
} else {
console.error(`Server responded with ${response.statusCode}: ${response.statusMessage}`);
response.resume(); // drain the response so the socket is released
resolve();
}
});

request.setTimeout(30000, () => {
request.destroy();
console.error(`Request timed out: ${url}`);
resolve();
});

request.on('error', err => {
console.error(err);
resolve();
Expand Down