Conversation
pheenomenon
approved these changes
Mar 19, 2025
Contributor
pheenomenon
left a comment
There was a problem hiding this comment.
LGTM, although I wonder why the webpcak changes from previous PR would come in the way of CI release.
Contributor
Author
After I looked into it further I discovered that it was problems with |
|
🎉 This PR is included in version 4.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Reverts changes done in a previous commit attempting to fix #157. The approach was incorrect and webpack should be used on the consuming library's end.
Reverting the change primarily because it seems it has broken the project's CI so that it's no longer able to release. If still needed, the original fix will need to be reworked.
Fixes #157 (revert)
Types of changes
Checklist: