Conversation
mfrisbey
left a comment
There was a problem hiding this comment.
Thank you! I agree with the change. Would you please update the README with instructions on how to re-enabled the log messages? Looking at the debug module, it seems like it has to do with setting the DEBUG environment variable. But I'd appreciate if you would test re-enabling them and adding the documentation.
Would you also please be sure that you've signed the Adobe CLA? The PR is failing with this message:
No signed agreements were found. Please [sign the Adobe CLA](http://opensource.adobe.com/cla.html)! Once signed, close and re-open your pull request to run the check again.
If you have any questions, contact Adobe's Open Source Office by mentioning them on the pull request with @adobe/open-source-office or via email [grp-opensourceoffice@adobe.com](mailto:grp-opensourceoffice@adobe.com).
If you believe this was a mistake, please report an issue at [adobe/cla-bot](https://github.com/adobe/cla-bot/issues).
|
Works as expected. Added debugging note to docs. There's a gotcha in this repo with the |
|
I'm looping in @pheenomenon to give final approval, since neither Tania or myself are actively involved in the maintenance of this library anymore. @pheenomenon wanted to make you aware of this work so that you can provide your input. |
|
@mfrisbey can you take another look and see if things are up to snuff. |
|
🎉 This PR is included in version 4.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
Intended to close #160 to avoid log pollution in downstream apps.
Only imported the already existing logger and replaced all
console.logwithlogger.info(in thelibdirectory).Fixes #160
Types of changes
Checklist: