Repository navigation
ecs 0.2.4, ecs-persistence 0.1.0: despawnWhere, System.describe, sync points between tiers, run changes, persisting by an app's trait - #240
Merged
Conversation
…wns, row loops and match, spawn's match and snapshot's where Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…pped on CI Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…e, sync points between tiers, a run's changes, @adobe/ecs-persistence 0.1.0 persisting by an app's trait Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…se with or not the snapshot's trait doesn't cover, and the guide's build reads past dot folders Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Syncs
ecs/from the ecs repository at244f952(Adobe-Firefly/ecs#7 and Adobe-Firefly/ecs#8).Closes #232, closes #233, closes #234, closes #236, closes #237, closes #238, closes #241. #235 and #239 are in
ecs/packages/ecs/followups.md.@adobe/ecs0.2.4:commands.despawnWhere({ with, not?, where? })despawns every entity a query matches at the sync point;wheretakes shared values, so a chunk unloads by its value.System.describe(system)gives a schedule's tiers, sync points, readonly systems and each system's inferred access, as data and text.components: { whole: true }takes it whole on purpose.Finalizer.changeswatches resources too, andworld.run(system, ...input, { changes: true })resolves to that run's own change set.commands.spawnTables(tables, { resources?, existing? }),whereon a readonly system'stables, andIndex.declarationOf(index).small archetypes 1K7.74 → 6.90 ns a row),up load(186 → 123 ms) andretag(35.5 → 30.0 ms). Across all 174 node benchmarks the mean change of the new features is +0.2%, each apparent slowdown within noise on rerun.@adobe/ecs-persistence0.1.0:snapshot({ world, by, ...selection })takes a trait the app declares, a symbol whose value is each component's or resource's saved name, and saves only what it covers.persistis removed.decode(bytes, { by })refuses bytes saved by another trait;encodeandspawnare unchanged.spawn({ world, snapshot, entities?, match? }):matchmerges a snapshot's entities into the world's by unique indexes, 906 → 409 ms at 1M matching all; spawn takes 163 ms at 1M, from 300 ms.matchfails, as data, for an index whose key,withornotnames a component the snapshot's trait doesn't cover.snapshot'swhereon shared components selects whole archetypes: one chunk of 10K among 1M snapshots in 0.13 ms and spawns back in 2.1 ms.@adobe/ecs-gpu0.0.2: its build keeps its keys top-levelconst, and it has guide chapters.pnpm-workspace.yamllistsecs-guide-checks, and the lockfile takes its entry (format v6). Nothing outsideecs/uses what changed.From a clean state,
check:workspace,build,typecheckand every package's full suite pass locally, with a GPU andCIunset:ecsecs-persistenceecs-gpuecs-guideecs-todo-vanillajsecs-sample-browserecs-particles-webgpuecs-transfers-canvasecs-gpu-viewsThe next
pnpm run publish <otp>here publishes@adobe/ecs0.2.4,@adobe/ecs-gpu0.0.2 and@adobe/ecs-persistence0.1.0.🤖 Generated with Claude Code