Repository navigation
Fix data-lit state setter and resize render loops - #231
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Prevent render loops caused by unstable state setters, unchanged state updates, and resize observer callback churn.
Compatibility
Mutating an object or array in place and passing the same reference to its state setter no longer requests a render. Consumers must provide a new reference for changed contents. External firefly-platform consumers have not been validated in this checkout.
Test Evidence
Regression coverage includes stable setters, repeated equal writes, NaN and signed zero semantics, nullish initialization and updates, independent state slots, observer reuse, latest callback delivery, memo stability, unchanged-width suppression, and unmount/remount cleanup.
PR Checklist
Jira Ticket
N/A (no ticket provided).
Related PRs
None.