fix: prevent plugin iframe blank on Library re-render#740
Merged
chrischrischris merged 5 commits intoadobe:mainfrom Feb 13, 2026
Merged
fix: prevent plugin iframe blank on Library re-render#740chrischrischris merged 5 commits intoadobe:mainfrom
chrischrischris merged 5 commits intoadobe:mainfrom
Conversation
688d30d to
2e9ecad
Compare
chrischrischris
previously approved these changes
Feb 4, 2026
chrischrischris
approved these changes
Feb 6, 2026
JackySun9
approved these changes
Feb 11, 2026
10 tasks
auniverseaway
added a commit
that referenced
this pull request
Feb 28, 2026
This reverts commit b39d8fc.
auniverseaway
added a commit
that referenced
this pull request
Feb 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes plugin iframe rendering blank when clicked immediately after opening the Library. The iframe src was being removed during re-render when library content loaded, leaving the plugin blank.
_activePanestate to track which plugin is currently activerepeat()with keys to preserve iframe DOM during re-rendersRelated Issue
Motivation and Context
When opening a plugin quickly after opening the Library (before all blocks/icons finish loading), the plugin iframe src attribute was removed during a re-render triggered by the library content load completion. This resulted in a blank iframe with cleared DOM.
How Has This Been Tested?
Local testing and browser override for da-bacom in the editor.
http://localhost:3000/edit#/aem-sandbox/block-collection/demo
https://plugin-render--da-live--brandon32.aem.page/
Types of changes
Checklist: