Skip to content

fix: prevent plugin iframe blank on Library re-render#740

Merged
chrischrischris merged 5 commits intoadobe:mainfrom
Brandon32:plugin-render
Feb 13, 2026
Merged

fix: prevent plugin iframe blank on Library re-render#740
chrischrischris merged 5 commits intoadobe:mainfrom
Brandon32:plugin-render

Conversation

@Brandon32
Copy link
Copy Markdown
Contributor

@Brandon32 Brandon32 commented Jan 29, 2026

Description

Fixes plugin iframe rendering blank when clicked immediately after opening the Library. The iframe src was being removed during re-render when library content loaded, leaving the plugin blank.

  • Added _activePane state to track which plugin is currently active
  • Used repeat() with keys to preserve iframe DOM during re-renders
  • Set iframe src only when plugin becomes the active pane

Related Issue

Motivation and Context

When opening a plugin quickly after opening the Library (before all blocks/icons finish loading), the plugin iframe src attribute was removed during a re-render triggered by the library content load completion. This resulted in a blank iframe with cleared DOM.

How Has This Been Tested?

Local testing and browser override for da-bacom in the editor.
http://localhost:3000/edit#/aem-sandbox/block-collection/demo
https://plugin-render--da-live--brandon32.aem.page/

  • Opening plugins immediately after Library opens and verified plugin loads correctly and iframe is not blank.
  • Added unit tests for active pane state management and iframe src updates

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

chrischrischris
chrischrischris previously approved these changes Feb 4, 2026
@aem-code-sync
Copy link
Copy Markdown

aem-code-sync Bot commented Feb 5, 2026

Page Scores Audits Google
📱 / PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ / PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@chrischrischris chrischrischris merged commit b39d8fc into adobe:main Feb 13, 2026
4 of 5 checks passed
auniverseaway added a commit that referenced this pull request Feb 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants