Conversation
No source changes needed — doc2aem/aem2doc come entirely from @adobe/da-parser. Adds a round-trip test covering the new link-img image delivery type. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
4 tasks
Revert @adobe/da-parser to ^2.1.0 -- no real published version exists yet for the link-img support (adobe/da-tools#27), and da-parser doesn't hand-bump its own version (semantic-release does that on merge). Bumping to ^2.2.0 is a required step before merging this PR, once that version is published. Update the round-trip test for da-parser's renamed marker: data-asset-delivery-type="link-img" -> data-edit-as="image". Verified passing against the (locally npm-linked) updated parser. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
shareddocround-trip test for da-parser's new link-img support (feat(da-parser): add link-img asset delivery type for image nodes da-tools#27): adata-edit-as="image"<a>persists viadoc2aemand reloads viaaem2doccorrectly (no<picture>). No source change needed —shareddoc.jsonly callsaem2doc/doc2aem, both from da-parser.@adobe/da-parserstays at^2.1.0for now — da-parser doesn't manually version itself (semantic-release does that on merge), so there's no real published version with this support yet. Verified the new test passes against the (locallynpm linked) updated parser.Before merging this PR: bump
@adobe/da-parserto whatever version gets published from adobe/da-tools#27.Test plan
npm test— 178 passing (against locally linked da-parser)npm run lint— clean🤖 Generated with Claude Code