Skip to content

Bugfix/create adbreak object#1473

Closed
tvanlaerhoven wants to merge 3 commits intoadobe:mainfrom
tvanlaerhoven:bugfix/create-adbreak-object
Closed

Bugfix/create adbreak object#1473
tvanlaerhoven wants to merge 3 commits intoadobe:mainfrom
tvanlaerhoven:bugfix/create-adbreak-object

Conversation

@tvanlaerhoven
Copy link
Copy Markdown

Description

When creating an AdBreak object, the createAdBreakObject builder internally swapped the podPosition and startTime properties. As a result, the POST request passing the /adBreakStart analytics event to the server would return with a 400 status.

Related Issue

#1472

Motivation and Context

This PR fixes the issue by passing the correct properties.

Checklist:

  • I have signed the Adobe Open Source CLA or I'm an Adobe employee.
  • I have made any necessary test changes and all tests pass.
  • I have run the Sandbox successfully.
  • I have added a Changeset (pnpm changeset) or it is not necessary because this PR is not consumer-facing.

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Mar 30, 2026

🦋 Changeset detected

Latest commit: 51b1fe3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@adobe/alloy-core Patch
@adobe/alloy-sandbox-browser Patch
@adobe/alloy Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@carterworks
Copy link
Copy Markdown
Collaborator

Those CI test failures are just flakes - they pass locally for me.

@carterworks
Copy link
Copy Markdown
Collaborator

Closes #1472

@jonsnyder
Copy link
Copy Markdown
Collaborator

Closed in favor of #1476

@jonsnyder jonsnyder closed this Apr 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants