Closed
Conversation
🦋 Changeset detectedLatest commit: 51b1fe3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
carterworks
approved these changes
Mar 30, 2026
Collaborator
|
Those CI test failures are just flakes - they pass locally for me. |
Collaborator
|
Closes #1472 |
4 tasks
Collaborator
|
Closed in favor of #1476 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When creating an AdBreak object, the
createAdBreakObjectbuilder internally swapped thepodPositionandstartTimeproperties. As a result, the POST request passing the/adBreakStartanalytics event to the server would return with a 400 status.Related Issue
#1472
Motivation and Context
This PR fixes the issue by passing the correct properties.
Checklist:
pnpm changeset) or it is not necessary because this PR is not consumer-facing.