Skip to content

Add directive to use .detached for commands that time out#428

Merged
riddhi2910 merged 1 commit into
masterfrom
detached-loging
Jun 4, 2026
Merged

Add directive to use .detached for commands that time out#428
riddhi2910 merged 1 commit into
masterfrom
detached-loging

Conversation

@riddhi2910

@riddhi2910 riddhi2910 commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

Description

when a long-running command times out: exec error: Command 'sleep 35' exceeded timeout of 30000ms
Adding directive to use .detached in the error message.

Motivation and Context

https://jira.corp.adobe.com/browse/ACNA-4664

How Has This Been Tested?

Yes, I manually tested it by linking the changes, creating a sandbox, and running a long-running command to verify the timeout behavior. I was able to reproduce the expected response:

exec error: Command 'sleep 35' exceeded timeout of 30000ms (use .detached for long-running commands)

I also ran npm test, and all tests passed.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 PR Reviewer

Small, focused change that adds a user-friendly hint to timeout error messages in the REPL. The implementation is clean and the test covers the new behavior adequately. No security, performance, or significant code quality concerns.

LGTM! This PR looks good to merge.


💡 How to re-trigger

Comment /review or /pr-reviewer on this PR

@codecov

codecov Bot commented Jun 4, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@riddhi2910 riddhi2910 merged commit fc61df2 into master Jun 4, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants