Add directive to use .detached for commands that time out#428
Merged
Conversation
There was a problem hiding this comment.
🤖 PR Reviewer
Small, focused change that adds a user-friendly hint to timeout error messages in the REPL. The implementation is clean and the test covers the new behavior adequately. No security, performance, or significant code quality concerns.
✅ LGTM! This PR looks good to merge.
💡 How to re-trigger
Comment /review or /pr-reviewer on this PR
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
MichaelGoberling
approved these changes
Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
when a long-running command times out: exec error: Command 'sleep 35' exceeded timeout of 30000ms
Adding directive to use .detached in the error message.
Motivation and Context
https://jira.corp.adobe.com/browse/ACNA-4664
How Has This Been Tested?
Yes, I manually tested it by linking the changes, creating a sandbox, and running a long-running command to verify the timeout behavior. I was able to reproduce the expected response:
exec error: Command 'sleep 35' exceeded timeout of 30000ms (use .detached for long-running commands)I also ran
npm test, and all tests passed.Screenshots (if appropriate):
Types of changes
Checklist: