fix(compliance): remove stale vector count from signed-requests-runner header - #6073
Draft
bokelley wants to merge 1 commit into
Draft
fix(compliance): remove stale vector count from signed-requests-runner header#6073bokelley wants to merge 1 commit into
bokelley wants to merge 1 commit into
Conversation
…r header The comment stated "28 conformance vectors" but the actual set has been 40 (12 positive + 28 negative) since 3.1.0. Replacing the hard-coded count with a directory reference matches the storyboard's own pass_criteria style and prevents future drift as vectors are added. Refs #6071
This was referenced Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6071
The header comment in
static/compliance/source/test-kits/signed-requests-runner.yamlsaid "28 conformance vectors" but the actual set has been 40 (12 positive + 28 negative) since 3.1.0. The count was never accurate for any released version — at 3.0.x the set was 39 (12 + 27), and "28" only happened to equallen(negative/)after vector028-unsigned-protocol-method-requiredwas added in 3.1.0. This PR removes the hard-coded count and replaces it with a directory reference (positive/ and negative/), matching the style used by the storyboard's ownpass_criteriablock, which deliberately avoids stating a total for the same reason.Non-breaking justification: Comment-only change in a YAML source file. No runner logic, schema field, or generated output is affected. Released dist artifacts (
dist/compliance/3.1.4/) remain immutable and carry the old wording by design; the fix ships into the next patch via source.Pre-PR review:
patchbump level correct per patch-eligibility table (non-normative compliance harness comment); dist immutability rule confirmed unaffectedSession: https://claude.ai/code/session_01EYYPbYTWZUnMa1KXb8tJZT
Generated by Claude Code