Skip to content

fix(compliance): remove tab character from runner-output-contract.yaml (backport 3.1.x) - #6065

Open
fgranata wants to merge 1 commit into
adcontextprotocol:3.1.xfrom
fgranata:backport/3.1.x-runner-output-tab
Open

fix(compliance): remove tab character from runner-output-contract.yaml (backport 3.1.x)#6065
fgranata wants to merge 1 commit into
adcontextprotocol:3.1.xfrom
fgranata:backport/3.1.x-runner-output-tab

Conversation

@fgranata

Copy link
Copy Markdown
Contributor

Backport of #6042 to the 3.1.x line, per the triage recipe on #6038 — cherry-pick of the merged main commit, no conflicts.

Note: v3.1.6 was cut before #6042 merged on main, so the shipped 3.1.6 cache still carries the malformed runner-output-contract.yaml; this backport is what gets the fix into the next 3.1.x cache release for platform-engine consumers.

Refs #6038

🤖 Generated with Claude Code

adcontextprotocol#6042)

A literal tab at line 303 (a pure comment line) makes the file
unparseable by strict YAML parsers — tabs cannot start a token — so
consumers of the packaged 3.1.4/3.1.5 compliance caches fail to load
the runner output contract. Replace the leading tab with spaces;
comment text and semantic content unchanged.

Verified: yaml.safe_load parses the file clean after the change, and
`grep -rP '^\t' static/compliance/source/` reports zero remaining
tab-leading lines (this was the only occurrence).

Refs adcontextprotocol#6038

Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
@fgranata
fgranata requested a review from a team as a code owner July 28, 2026 11:42

@aao-secretariat aao-secretariat Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Argus review could not complete

The automated review encountered an issue (possibly reached max turns, timed out, or failed to post the final gh pr review). A human reviewer should take this PR.

View workflow run

This is an automated message from the Argus AI review workflow.

@fgranata

Copy link
Copy Markdown
Contributor Author

Gentle nudge for prioritization: @adcp/sdk@13.0.0-rc.3 (published yesterday) carries a freshly cut 3.1.8 compliance cache, and it still contains the tab — compliance/cache/3.1.8/universal/runner-output-contract.yaml line 269 has a literal tab character, so strict YAML parsers (yaml.safe_load) still fail on it:

yaml.scanner.ScannerError: ... in "runner-output-contract.yaml", line 269, column 1

So new 3.1.x caches are being cut without this backport, and platform engines that strict-parse the cache keep degrading. Merging this before the next 3.1.x cache cut would get the fix (already on main via #6042) into the published caches. Happy to rebase if anything's needed on my side.

@bokelley

Copy link
Copy Markdown
Contributor

Confirming status after @fgranata's note:

CI: all 9 checks green (CodeQL, TypeScript Build, Server integration tests, changeset, PR title, code_review, GitGuardian, Analyze). mergeable_state: clean — no conflicts.

One blocker: the Argus automated review timed out and posted a warning that a human reviewer should take this PR before merge. That's the only thing between this and landing.

Escalated impact: the PR description cited v3.1.6 as the last affected release. @fgranata's comment confirms @adcp/sdk@13.0.0-rc.3 (published 2026-07-28) ships a 3.1.8 compliance cache that still carries the tab at line 269. Every 3.1.x cache cut until this merges ships the malformed file to strict-YAML consumers.

Ready for a quick human review pass — the diff is +11/-1, one file.


Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants