Repository navigation
fix: peer dependency ranges state what the code needs - #48
Merged
Merged
Conversation
…pdated - peers: @adaptivestone/framework ^5.1.0, mongoose ^9.0.0, AWS SDK clients ^3.572.0 (was `*`) - @aws-sdk/client-sqs before 3.572 silently drops MessageSystemAttributeNames, so every delivery read as attempt 1 and a failing task was never dead-lettered; SqsTaskQueue now also warns once when SQS returns no ApproximateReceiveCount - dev: framework 5.5, mongoose 9.11, AWS SDK 3.1146, @types/node 26.6.4 - README install table and AGENTS.md list the minimum versions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The optional peers were declared as
*(any version), and the framework as^5.0.1. That claimed compatibility with versions the code doesn't work with.A real bug behind it
SqsTaskQueuegets the attempt count fromApproximateReceiveCount, which it requests withMessageSystemAttributeNames. That parameter exists only from@aws-sdk/client-sqs3.572.0 (I bisected the published packages: 3.569.0 doesn't have it, 3.572.0 does). An older client silently drops it. Every delivery then reads as attempt 1, so a failing task is never dead-lettered and is retried forever.*allowed exactly that.Changes
Peers (all still optional):
@adaptivestone/framework^5.1.0mongoose^9.0.0@aws-sdk/client-sqs^3.572.0@aws-sdk/client-s3,@aws-sdk/s3-request-presigner^3.572.0Warning:
SqsTaskQueuewarns once when SQS returns noApproximateReceiveCount, so an old or unusual client is visible in the logs. New test included.Dev versions updated to the latest on npm: framework 5.5.0, mongoose 9.11.0, AWS SDK 3.1146.0,
@types/node26.6.4.Docs: the README install table and AGENTS.md list the minimum versions; CHANGELOG entry added.
Checks
611 tests (609 pass, 2 skipped as before) against the updated dev versions.
tsc,types:check, Biome, build and smoke pass.Not covered: CI tests only the latest versions, not the floors. A job that also tests the minimums would need its own lockfile.