remove i2sin invert_bit_clock argument - #11177
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This argument was initially added during development at a time when I turned out to be mistaken about the behavior of the NAU88L21. I've since realized it isn't necessary for that codec. I think it's possible a device could exist that either uses this communication protocol, or can be optionally configured to do so. But it doesn't seem to be particularly standard, I couldn't find a specific instance of it, so I think it's worth just dropping it.
Also updated a comment for the left_justified change from #11170. Not directly related to invert_bit_clock but noticed while updating code nearby.
I tested the TE EP2350 guide project code successfully with this change to ensure no regression.