Skip to content

update ulab to 6.12 + latest fix 2b6e0cf - #11131

Draft
dhalbert wants to merge 5 commits into
adafruit:mainfrom
dhalbert:ulab-update
Draft

dhalbert wants to merge 5 commits into
adafruit:mainfrom
dhalbert:ulab-update

Conversation

@dhalbert

Copy link
Copy Markdown
Collaborator

6.12 is is latest tag, but also include one fix past that, v923z/micropython-ulab#750, which is meant to be 6.12.1 but hasn't been released yet.

FYI @v923z

@dhalbert dhalbert self-assigned this Jul 20, 2026
dhalbert and others added 3 commits July 21, 2026 22:19
The 6.12 ulab update added the ndarray % operator (~3.9kB) and a new
scipy.integrate module (~4.0kB), pushing size-constrained boards over.
Disable both by default.

The scipy.integrate disable is groundwork: ULAB_SCIPY_HAS_INTEGRATE_MODULE
does not yet drop the module's code upstream (the flag only gates the scipy
namespace entry). It becomes an actual size win once the upstream ulab fix
lands and the submodule is bumped.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@dhalbert

Copy link
Copy Markdown
Collaborator Author

Needs merge of v923z/micropython-ulab#751 before finishing.

@dhalbert
dhalbert marked this pull request as draft July 22, 2026 17:31
@dhalbert

Copy link
Copy Markdown
Collaborator Author

v923z/micropython-ulab#751 now merged upstream.

@tannewt

tannewt commented Sep 23, 2026

Copy link
Copy Markdown
Member

Can we do this now?

@dhalbert

Copy link
Copy Markdown
Collaborator Author

Can we do this now?

No, sorry, there are several issues and pull requests in ulab that haven't been acted on, including failing tests. I can push this forward later, forking if needed. Or I will submit easy PR's to approve.

@v923z

v923z commented Sep 23, 2026

Copy link
Copy Markdown

Can we do this now?

No, sorry, there are several issues and pull requests in ulab that haven't been acted on, including failing tests. I can push this forward later, forking if needed. Or I will submit easy PR's to approve.

Which are the critical bugs that should be fixed?

@dhalbert

Copy link
Copy Markdown
Collaborator Author

Hi @v923z: v923z/micropython-ulab#753 and v923z/micropython-ulab#755 should be addressed. See v923z/micropython-ulab#756 as well. The tests are failing without those, so we can't upgrade as is.

You talked about using isclose() v923z/micropython-ulab#755 (comment), and I had a mind to do that across all the tests with an LLM, but haven't gotten to it.

@v923z

v923z commented Sep 23, 2026

Copy link
Copy Markdown

I've merged the first PR, the second is a draft. You're right, isclose would be the right fix, but I'd be OK with merging v923z/micropython-ulab#755.

@dhalbert

Copy link
Copy Markdown
Collaborator Author

@v923z Thank you! I'm going to submit a PR is just the break vs. continue fix in v923z/micropython-ulab#755. That will not pass tests, but it will set the stage for an isclose() PR, which I'll then have an LLM do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update ulab to 6.12.1-2D

3 participants