chore(dev): adopt pre-commit hooks#144
Merged
tekktrik merged 1 commit intoadafruit:mainfrom Jan 31, 2026
Merged
Conversation
2bndy5
force-pushed
the
pre-commit
branch
2 times, most recently
from
c9a1290 to
9de708c
Compare
This comment was marked as resolved.
This comment was marked as resolved.
tekktrik
requested changes
Jan 30, 2026
Member
tekktrik
left a comment
tekktrik
left a comment
There was a problem hiding this comment.
Some changes and requests for clarification but this is great that were almost there.
Member
|
Regarding some similar workflow, there is a much larger one that handles things for libraries that are not applicable here (e.g., sphinx documentation and running |
This comment was marked as resolved.
This comment was marked as resolved.
tekktrik
approved these changes
Jan 31, 2026
Member
tekktrik
left a comment
tekktrik
left a comment
There was a problem hiding this comment.
Looks great - thanks for you work on this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #138
Requires the following PRs merged before review:
__init__.pyfiles #141The pre-commit config was adapted from adafruit/Adafruit_CircuitPython_PCA9554 project's config, but with version upgrades for the specified hooks.
The added CI workflow is just something I whipped up. Maybe there's a Adafruit-maintained reusable workflow of which I'm unaware.