fix(deps): move @huggingface/transformers to optionalDependencies#248
Conversation
sharp (pulled in by @huggingface/transformers) has no prebuilt binary for Node v26 on macOS and requires node-gyp to build from source. Since embeddings are already opt-in (hivemind embeddings install), marking the dep optional prevents install failures on unsupported Node versions.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe pull request moves ChangesDependency Management
Estimated code review effort🎯 2 (Simple) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Coverage ReportNo Generated for commit 7f61481. |
Summary
@huggingface/transformersfromdependenciestooptionalDependenciessharp(transitive dep via@huggingface/transformers) has no prebuilt binary for Node v26 on macOS and requiresnode-gypto build from source, causingnpm install -g @deeplake/hivemindto failhivemind embeddings install) and the code already handles the package being absent gracefully — this aligns the package.json with runtime behaviorTest plan
npm install -g @deeplake/hivemindsucceeds on Node v26 macOS withoutnode-gypinstalledhivemind embeddings installstill works and downloads@huggingface/transformerson demandSummary by CodeRabbit