fix: parse comments in .nvmrc files#1586
Open
bm1016bm-svg wants to merge 1 commit into
Open
Conversation
bm1016bm-svg
marked this pull request as ready for review
July 17, 2026 09:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1119.
getNodeVersionFromFile()already handles a full-line comment followed by a version in many cases, but some valid.nvmrccomment forms are still parsed as part of the Node version. In particular, a comment-only#line can be selected as the version, and inline comments or trailing whitespace can leave an invalid version string.This change applies
.nvmrc-specific preprocessing before the existing version matcher:#commentsnullwhen the file contains only comments or whitespaceThe behavior of
.tool-versions, JSON package files, and Volta configuration is unchanged. Thanks to @sodic for documenting the failing cases in #1119.The committed
dist/setupanddist/cache-savebundles were rebuilt from the updated source.Validation
npm run pre-checkinnpm run format-checknpm run lintnpm test— 11 suites and 235 tests passedgit diff --check