Skip to content

Fix regex pattern in csc.json #691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jguddas wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix regex pattern in csc.json #691

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/csc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"owner": "csc",
"pattern": [
{
"regexp": "^([^\\s].*)\\((\\d+)(?:,\\d+|,\\d+,\\d+)?\\):\\s+(error|warning)\\s+([a-zA-Z]+(?<!MSB)\\d+):\\s*(.*?)\\s+\\[(.*?)\\]$",
"regexp": "^(.*)\\((\\d+)(?:,\\d+|,\\d+,\\d+)?\\):\\s+(error|warning)\\s+([a-zA-Z]+(?<!MSB)\\d+):\\s*(.*?)\\s+\\[(.*?)\\]$",
Copy link

Copilot AI Dec 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The regex pattern change from ^([^\\s].*) to ^(.*) makes the pattern overly permissive. While it solves the issue of matching lines starting with spaces, it also allows matching lines that start with whitespace-only content or even empty filenames.

Consider using ^(\\s*.+) instead, which explicitly allows optional leading whitespace but still requires at least one character for the filename. This maintains the intent of matching paths with leading spaces while preventing potential false positives from empty or whitespace-only matches.

Copilot uses AI. Check for mistakes.
"file": 1,
"line": 2,
"severity": 3,
Expand Down