Fix autocomplete showing mapping keys for empty values #268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericsciple
force-pushed
the
users/ericsciple/25-12-options
branch
from
6d803ff to
9ca0859
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes autocomplete behavior to prevent mapping keys from appearing when completing inline values (Key mode). When a user types key: | (cursor after colon), the completion should only suggest inline scalar values, not mapping keys that would require a newline and indentation.
Key Changes:
- Modified
oneOfValuesto filter out mapping variants in Key mode when no structure is committed - Updated test expectations to verify that mapping keys are excluded in Key mode scenarios
- All affected tests now correctly expect only scalar completions (or no completions) at inline positions
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| languageservice/src/value-providers/definition.ts | Added logic to skip mapping variants in Key mode when user hasn't committed to a structure (lines 209-211), preventing confusing newline-based completions for inline value positions |
| languageservice/src/complete.test.ts | Updated test names, comments, and expectations to reflect new behavior where mapping keys are filtered in Key mode (e.g., `permissions: |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ericsciple
force-pushed
the
users/ericsciple/25-12-options
branch
2 times, most recently
from
662015c to
90b57e3
Compare
Follow-up to #265 When completing an empty value (e.g., `permissions: |`), mapping keys were incorrectly shown alongside scalar values. This made completions confusing. Before: - `permissions: |` showed read-all, write-all, AND actions, contents, etc. - `on: |` showed check_run AND check_run (full syntax), etc. After: - `permissions: |` shows only read-all and write-all - `on: |` shows only event names like push, check_run - `concurrency: |` shows no completions (user types their own group name) Users who want the mapping form choose (full syntax) completions at the parent level.
ericsciple
force-pushed
the
users/ericsciple/25-12-options
branch
from
90b57e3 to
da716cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to PR:
Bug
When completing an empty value (e.g.,
permissions: |), mapping keys were incorrectly shown alongside scalar values. This made completions confusing:Before:
permissions: |showedread-all,write-all, ANDactions,contents, etc.on: |showedcheck_runANDcheck_run (full syntax), etc.After:
permissions: |shows onlyread-allandwrite-allon: |shows only event names likepush,check_runconcurrency: |shows no completions (user types their own group name)Users who want the mapping form choose
(full syntax)completions at the parent level (e.g.,permissions (full syntax)).