Fix ghost error in validation function when group node has issues#25
Merged
sebastianrath merged 1 commit intomainfrom Feb 17, 2026
Merged
Fix ghost error in validation function when group node has issues#25sebastianrath merged 1 commit intomainfrom
sebastianrath merged 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a cascading validation error in group nodes where a sub-graph error causes the parent graph to falsely report the group node as non-existent. While the group node may have issues, it should be still considered as existing, otherwise it would lead to a misleading error.
So for example when a
core/group@v1node has some errors, the group factory returned nil instead of the group node. This caused the group node to never be registered in the parent graphs node map, producing a misleading secondary error for any connection referencing the group.Before:
Error 2 is a false positive, node
gis declared in the graph, just has a bug.Now:
Example graph error: