Conversation
Spotted in production - on chains where there is consecutive MDC config (i.e. 1 block, 2 blocks, 3 blocks), there ends up being a gap in the resulting config. This imposes an unintended delay on filling some higher-value deposits.
pxrl
requested review from
bmzig,
dohaki,
mrice32 and
nicholaspai
as code owners
bmzig
reviewed
Jan 5, 2026
| const limits = mdcs.map(({ usdThreshold, minConfirmations }, idx) => { | ||
| const toBlock = Math.max(head - minConfirmations, deploymentBlock); | ||
| const fromBlock = | ||
| idx < mdcs.length - 1 ? Math.max(head - mdcs[idx + 1].minConfirmations + 1, 0) : deploymentBlock; |
Contributor
There was a problem hiding this comment.
Why do we need to query the origin chain commitment from [head - mdc[x-1], head - mdc[x]]? If I'm understanding this correctly, if we have head at block 15, fills every block from [10, 15], and mdcs [100: 1, 300: 3] as an example, then does this mean the commitment for the mdc at 300 only accounts for fills from [deployment, 12]? If so, why should it not account for the fills at blocks 13+?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spotted in production - on chains where there is consecutive MDC config (i.e. 1 block, 2 blocks, 3 blocks), there ends up being a gap in the resulting config. This imposes an unintended delay on filling some higher-value deposits.