refactor: bridges should not be opinionated on src/dst chains#2727
Closed
bmzig wants to merge 3 commits intobz/generalization1from
Closed
refactor: bridges should not be opinionated on src/dst chains#2727bmzig wants to merge 3 commits intobz/generalization1from
bmzig wants to merge 3 commits intobz/generalization1from
Conversation
Signed-off-by: Bennett <bennett@umaproject.org>
bmzig
requested review from
dohaki,
mrice32,
nicholaspai and
pxrl
as code owners
Signed-off-by: Bennett <bennett@umaproject.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: This PR only renames state variables/files/directories. As we move more toward any<->any rebalancing capabilities, we should separate the "opinionated" bridges from others. Bridges which only exist on one network and move to another, such as all the canonical L1/L2 bridges (ex CCTP, OFT), should instead be treated as directed edges and those which can move assets from any network to any other network should be undirected.
One obvious follow-up: All l2 bridges need to implement
BaseBridgeAdapterinstead ofBaseL2BridgeAdapter(meaning the queryL2/L2Event functions need to be generalized).