feat: wire diagnostic costs into profile triage pairs - #309
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completes the in-progress wiring of caller-verified diagnostic costs (VCR405, #307) into the paired-trial harness. Builds on an uncommitted work-in-progress edit that previously crashed
ProfileTriageSpecconstruction and failed the local suite (8 errors). Also fixes a pre-existing argv-order divergence so rank-plus-observation triage commands are intercepted by the bridge instead of silently falling back to the real interpreter.Change
triage.diagnostic_costsfor supplied hypothesis IDs only (plain-string enum tokens, loader-validated).ProfileTriageSpecgains a validateddiagnostic_costsfield (plain strings only; they are embedded verbatim in the generated shim).command_for, the intercepted python shim, the bridge request contract, and_decideforward the costs end to end, so cost-bearing triage requests stay bridge-counted instead of silently falling back to the real CLI, and the tokens reach the productiontriage_failuredecision state._triage_argvnow places observation flags before--rank-hypotheses, matchingcommand_forand the shim; previously the exact command for a rank-plus-observation profile was rejected by the shim's parser and fell back to the real interpreter, bypassing bridge call counting and receipts.Evidence (local, offline)
tests/test_pilot_profile_diagnostic_costs.py: loader accept/reject, equal-arm disclosure, supervisor argv construction, spec validation, bridge request matching/forwarding, shim interception without fallback, and rank-plus-observation command order (verified to fail against the pre-fix ordering).git diff --checkclean.Local results only — the required hosted CI check must be green before merge. No trial was run; no efficacy, delivery, or release claim. No historical trial is rescored or rerun.