Fix CMake MSVC runtime override when CMAKE_MSVC_RUNTIME_LIBRARY is us…#2107
Open
ishatiwari21 wants to merge 1 commit into
Open
Fix CMake MSVC runtime override when CMAKE_MSVC_RUNTIME_LIBRARY is us…#2107ishatiwari21 wants to merge 1 commit into
ishatiwari21 wants to merge 1 commit into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates
CMakeLists.txtso thatCMAKE_MSVC_RUNTIME_LIBRARYis only set when it has not already been defined.Motivation
Currently, Abseil unconditionally overwrites
CMAKE_MSVC_RUNTIME_LIBRARY, preventing users from specifying their preferred MSVC runtime through the command line or the CMake cache. This makes it difficult for projects integrating Abseil to control the runtime library consistently across their build.Changes
CMAKE_MSVC_RUNTIME_LIBRARYif it is not already defined.ABSL_MSVC_STATIC_RUNTIMEfor selecting the default static or dynamic runtime when no explicit runtime has been provided.Impact
This change is backward compatible. Existing users who do not explicitly configure
CMAKE_MSVC_RUNTIME_LIBRARYwill see no behavioral change, while users who do configure it will have their setting preserved.Fixes #2084.