Add support for all osv ecosystems#926
Merged
TG1999 merged 1 commit intoaboutcode-org:mainfrom Feb 13, 2024
Merged
Conversation
ziadhany
force-pushed
the
osv_ecosystem
branch
from
64dc907 to
87abb5b
Compare
TG1999
reviewed
Nov 21, 2022
ziadhany
force-pushed
the
osv_ecosystem
branch
from
87abb5b to
f35ed57
Compare
Collaborator
Author
|
importer logs : improver logs : |
Contributor
|
@ziadhany we should also support |
ziadhany
force-pushed
the
osv_ecosystem
branch
from
f35ed57 to
4064dbd
Compare
Collaborator
Author
I don't think we support |
Contributor
|
@ziadhany you can use |
ziadhany
force-pushed
the
osv_ecosystem
branch
from
4064dbd to
309fd36
Compare
Contributor
|
@ziadhany please attach logs for importer and improver |
Collaborator
Author
|
ziadhany
force-pushed
the
osv_ecosystem
branch
from
309fd36 to
09ef8dd
Compare
TG1999
reviewed
Jan 24, 2023
| try: | ||
| yield parse_advisory_data( | ||
| raw_data, | ||
| supported_ecosystems=[ |
Collaborator
Author
There was a problem hiding this comment.
I think I should add mapper for ecosystems , OSV relay on RANGE_CLASS_BY_SCHEMES : gems but osv call the ecosystem : rubygems
Member
There was a problem hiding this comment.
It would make sense to use a variable for the list of ecosystems as it does not help reading to have a long list of values in a function arguments.
And surely you need a mapping for OSV to PURL types that's at https://github.com/nexB/vulnerablecode/pull/926/files#diff-33c32124a3048b04cb219fc5540512cf1c658d638b86bc51e2e74a477de15dd5R33
Contributor
|
@ziadhany as I can see the improver logs some URLs doesn't look valid, can you please look into the reason for this ? |
ziadhany
force-pushed
the
osv_ecosystem
branch
2 times, most recently
from
c2a9677 to
cc3c549
Compare
Collaborator
Author
|
@TG1999 I am a little confused, Is this a bug in univers? importer logs : github_osv_importer.log |
Contributor
|
@ziadhany instead of deduping list of |
Collaborator
Author
@TG1999 All the ecosystems work except ruby, so I think it is a |
Member
Yes, this is a univers bug |
pombredanne
added a commit
to ziadhany/univers
that referenced
this pull request
Feb 10, 2023
Reference: aboutcode-org/vulnerablecode#926 Reference: aboutcode-org/vulnerablecode#608 Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Contributor
|
@ziadhany please update univers to v30.9.2 |
ziadhany
force-pushed
the
osv_ecosystem
branch
from
f286880 to
550a765
Compare
Member
|
#749 See that |
Contributor
|
@ziadhany please resolve the conflicts |
ziadhany
force-pushed
the
osv_ecosystem
branch
from
550a765 to
73979eb
Compare
Collaborator
Author
Done |
ziadhany
force-pushed
the
osv_ecosystem
branch
from
73979eb to
1dcdd7b
Compare
TG1999
changed the title
ziadhany
force-pushed
the
osv_ecosystem
branch
2 times, most recently
from
045c60d to
b7f4670
Compare
TG1999
changed the title
TG1999
requested changes
Feb 5, 2024
Contributor
TG1999
left a comment
TG1999
left a comment
There was a problem hiding this comment.
Some nits for your consideration!
ziadhany
force-pushed
the
osv_ecosystem
branch
from
b7f4670 to
e4a57ca
Compare
Collaborator
Author
Done |
Add a GithubOSVImporter to git_importer parametrize test Refactor OSV ecosystem mapping Fix the test Update univers version and pass nuget test Resolve merge conflict Add a test for golang Fix test by adding cwe to expected files Resolve merge conflict Signed-off-by: ziadhany <ziadhany2016@gmail.com>
ziadhany
force-pushed
the
osv_ecosystem
branch
from
b53bb26 to
5d18863
Compare
Collaborator
Author
Done , but I can't merge because the docs CI is falling |
Contributor
|
@ziadhany thanks++ |
Closed
TG1999
pushed a commit
to TG1999/vulnerablecode
that referenced
this pull request
Jul 19, 2024
Add a GithubOSVImporter to git_importer parametrize test Refactor OSV ecosystem mapping Fix the test Update univers version and pass nuget test Resolve merge conflict Add a test for golang Fix test by adding cwe to expected files Resolve merge conflict Signed-off-by: ziadhany <ziadhany2016@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: ziadhany ziadhany2016@gmail.com