UTS: rest/unit housekeeping fixes - #538
Open
owenpearson wants to merge 1 commit into
Open
owenpearson wants to merge 1 commit into
owenpearson wants to merge 1 commit into
Conversation
Removes a leaked absolute developer path, adds missing Test IDs, resolves a duplicate RSC17 test, relocates misfiled Realtime tests, corrects bad header claims (RSN3b/c, RSC7b), and loosens an over-specified RSC18 timing assertion. Closes #532 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the seven housekeeping faults in
uts/rest/unit/described in #532. All changes are confined touts/.Checklist
/Users/paddy/data/worknew/dev/dart-experiments/uts/rest/unit/rest_client.mdwith the repo-relativeuts/rest/unit/rest_client.mdin all six offenders (channel/publish.md,channel/history.md,channel/idempotency.md,encoding/message_encoding.md,presence/rest_presence.md,types/paginated_result.md), matching the convention already used by their one-level-down neighbours. Preserved each file's existing "defined in" / "described in" wording.RSAN2a/delete-post-annotation-delete-0,RSAN3b/get-sends-get-0,RSAN3c/get-returns-paginated-result-0,RSAN3b/get-params-querystring-1(all inchannel/annotations.md), andRSL6a3/msgpack-fixtures-decode-0/RSL6a3/msgpack-fixtures-round-trip-1(inencoding/msgpack_interop.md).## RSC17 - ClientId Attributesection (client-id-matches-auth-1). The clientId-from-token case it was meant to cover is already tested byRSA7b - clientId from TokenDetailsinauth/client_id.md, so writing a token-based test here would only duplicate that; the survivingclient-id-from-options-0section already assertsclient.clientId == client.auth.clientId.REC3,REC3a,REC3bconnectivity-check sections out ofrest/unit/fallback.mdinto a newuts/realtime/unit/connection/connectivity_check_test.md, reindexing their IDs to therealtime/unit/...category. DroppedREC3,REC3a,REC3bfrom thefallback.mdheader spec-points list.channels_collection.md:3; noget(name, options)call exists anywhere inuts/, so there is nothing to test (and RSN3c is soft-deprecated).rest_client.md:3; RSC7b is superseded by RSC7d per features.md, so a test would be wrong to write. Left the umbrellaRSC7in place (its children RSC7c/d/e are tested).RSC18/basic-auth-over-http-rejected-1to accept failure at either construction or request time: it now constructs the client, attempts a request, and asserts an error surfaced by the time the request would have gone out with no request reaching the mock. Also removed the non-spec-derivederror.code == 40103assertion arm (keeping the message-based arms), since40103does not appear in features.md.Item 7 caveat
The issue notes
40103is absent fromfeatures.md. Per this PR's scope I did not editspecifications/. The UTS-side resolution (loosening the assertion and dropping the un-derived error-code check) is done here. If constructor-time failure or the40103code is intended to be normative, that belongs in a separate features.md change to RSC18/RSA1.Files changed
uts/rest/unit/channel/publish.md,history.md,idempotency.mduts/rest/unit/encoding/message_encoding.md,msgpack_interop.mduts/rest/unit/presence/rest_presence.mduts/rest/unit/types/paginated_result.mduts/rest/unit/channel/annotations.mduts/rest/unit/channels_collection.mduts/rest/unit/rest_client.mduts/rest/unit/fallback.mduts/realtime/unit/connection/connectivity_check_test.md(new)Merge order
PR 7 of 7 — merge LAST. It touches
fallback.mdandrest_client.md(shared with the mock-HTTP PR) and several files shared with other PRs in the batch, so rebase after the rest of the batch has merged.Closes #532
🤖 Generated with Claude Code