UTS: drive the RSA4b renewal test off a normal request instead of /time - #533
Open
owenpearson wants to merge 1 commit into
Open
owenpearson wants to merge 1 commit into
owenpearson wants to merge 1 commit into
Conversation
The renewal-msgpack test drove token renewal through /time, which requires no auth and so cannot exercise renewal-on-request. Reworks it to use a normal authenticated request, matching the RSC10/request-retried-after-renewal-0 template. Closes #530 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #530. The
rest/unit/RSA4b/renewal-msgpack-response-4test drove token renewal throughclient.time(). The/timeendpoint requires no auth (per RSC16 and the note inuts/rest/unit/time.md:21), so it can never obtain a token, fail on it, or trigger renewal — making the test'scallback_count == 2assertion unsatisfiable and mutually exclusive withRSC16/no-auth-required-2.The msgpack error-decoding subject of the test is sound; only the endpoint was wrong. The test is reworked to drive renewal via a normal authenticated request (
channel.status()), following the existing in-repo templateRSC10/request-retried-after-renewal-0in the same file.Changes
uts/rest/unit/auth/token_renewal.md:client.time()→client.channels.get("test").status()msgpack_encode([1234567890000])→ msgpack-encoded channel status bodyresult == 1234567890000→result IS ChannelDetailsThe 401 msgpack error response (40142) and the
callback_count == 2/request_count == 2assertions carry over unchanged, so the msgpack error-decoding behaviour the test exists for is preserved. Nospecifications/(features.md) change required.Merge order
PR 2 of 7. Largely standalone — only shares
uts/rest/unit/auth/token_renewal.mdwith the deferred #529, which is not in this batch.🤖 Generated with Claude Code