Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Implements the policy proposed in abhiksark#133, scoped to what it asks for: * checks/**/*.py ignores F821 only — those undefined names come from the learner namespace the runner resolves at runtime, so they are expected rather than defects; * ruff moves into the dev extra so the config is reachable from pip install -e .[dev]. No global select/ignore block is added: Ruff stays on its defaults so the checks/ exception is the only new policy, and the remaining violations stay open for their own pass.
mercael91
force-pushed
the
fix/issue-133
branch
from
September 25, 2026 06:43
2cfbae3 to
e867036
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the policy proposed in #133, scoped to what it asks for:
[tool.ruff.lint.per-file-ignores]with"checks/**/*.py" = ["F821"]— those undefined names come from the learner namespace the runner resolves at runtime, so they are expected rather than defects;ruff>=0.6.0in thedevextra, so the config is reachable from a plainpip install -e .[dev].No global
select/ignoreblock is added: Ruff stays on its defaults, so thechecks/exception is the only new policy and the rest stays open for its own pass.Measured with ruff 0.16.9 on this checkout: F821 drops from 2267 findings to 1079, i.e. the
checks/tree accounts for ~1188 of them. The remaining ~1079 are inexercises/andsolutions/(same learner-stub reason) and are deliberately left alone. E501 and the other ~212 violations are untouched — 1244 findings before and after.