Skip to content

fix: restore package-lock.json + legacy-peer-deps to unblock CI and release#80

Merged
ThePlenkov merged 3 commits intomainfrom
copilot/remove-package-lock-and-run-bun
Mar 11, 2026
Merged

fix: restore package-lock.json + legacy-peer-deps to unblock CI and release#80
ThePlenkov merged 3 commits intomainfrom
copilot/remove-package-lock-and-run-bun

Conversation

Copy link
Contributor

Copilot AI commented Mar 11, 2026

Nx 22.x cannot parse Bun's text-based bun.lock format (introduced in Bun 1.2), causing nx affected to fail with externalDependency 'eslint' could not be found. The original nx release failure was a separate ERESOLVE from npm install conflicting on eslint-plugin-import@2.32.0 peer deps against eslint@10.

Changes

  • package-lock.json — restored; Nx 22 requires a committed npm lockfile to hash external dependencies
  • nx.json — reverted cli.packageManager back to npm to match the lockfile
  • .npmrc — added legacy-peer-deps=true to suppress the peer dep conflict when npm install runs during nx release version bumps
  • .gitignore — removed the package-lock.json exclusion added in the previous commit

Note: Full elimination of package-lock.json in favour of bun.lock requires upgrading Nx to v23+, which ships a Bun lockfile parser. Until then, legacy-peer-deps is the minimal fix to keep both CI and the release workflow green.


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

…ager

Co-authored-by: ThePlenkov <6381507+ThePlenkov@users.noreply.github.com>
Copilot AI changed the title [WIP] Remove package-lock and run bun install fix: remove package-lock.json, switch Nx to bun Mar 11, 2026
@ThePlenkov ThePlenkov marked this pull request as ready for review March 11, 2026 15:15
Copilot AI review requested due to automatic review settings March 11, 2026 15:15
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Aligns Nx release behavior with the repo’s Bun-based install workflow by preventing Nx from using npm/package-lock.json during version bump/release steps.

Changes:

  • Switch Nx CLI package manager from npm to bun in nx.json.
  • Remove package-lock.json from the repository (per PR description).
  • Add package-lock.json to .gitignore to prevent reintroduction.

Reviewed changes

Copilot reviewed 1 out of 3 changed files in this pull request and generated no comments.

File Description
nx.json Configures Nx to use Bun as the package manager (affects nx release install/lockfile updates).
.gitignore Prevents package-lock.json from being re-added.
package-lock.json Removed to stop Nx from triggering npm lockfile updates (per PR description).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

…acy-peer-deps

Co-authored-by: ThePlenkov <6381507+ThePlenkov@users.noreply.github.com>
Copilot AI changed the title fix: remove package-lock.json, switch Nx to bun fix: restore package-lock.json + legacy-peer-deps to unblock CI and release Mar 11, 2026
@nx-cloud
Copy link
Contributor

nx-cloud bot commented Mar 11, 2026

View your CI Pipeline Execution ↗ for commit 1bbf03d

Command Status Duration Result
nx affected -t lint test build e2e-ci --verbose... ✅ Succeeded <1s View ↗

☁️ Nx Cloud last updated this comment at 2026-03-11 15:32:06 UTC

@sonarqubecloud
Copy link

@ThePlenkov ThePlenkov merged commit a1e4e15 into main Mar 11, 2026
3 checks passed
@ThePlenkov ThePlenkov deleted the copilot/remove-package-lock-and-run-bun branch March 11, 2026 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants