Repository navigation
Remove Family price proxy from CoW swap pricing - #3166
Merged
Merged
Conversation
CoW swap quotes now take token USD prices only from CoW's price endpoint (bff.cow.fi), which was already the fallback. Family's backend is being deprecated, and across Aave reserves on CoW chains CoW prices every token Family does and sits closer to the Aave oracle where the two disagree. Drops FamilyPricesService, the /api/prices-proxy route, the FAMILY_API_* env vars, and the custom-token flags that only gated the Family call.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
📦 Next.js Bundle Analysis for aave-uiThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
sammdec
approved these changes
Nov 3, 2026
AGMASO
approved these changes
Nov 3, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What to review
rates.helpers.ts:getCowProtocolSellRatesnow prices both tokens withCoWProtocolPricesServicedirectly. The Family-firstgetTokenUsdPricehelper is gone.useSwapQuote.tsandquote.types.ts: dropisInputTokenCustom/isOutputTokenCustom, which only decided whether to skip Family.FamilyPricesService.ts,pages/api/prices-proxy.tsand its.md, andFAMILY_API_*in.env.exampleand.env.development.Why
Family's backend is being deprecated. The interface only used it for token USD prices in CoW swap quotes, with CoW's
bff.cow.fiendpoint as the fallback (and already the only source on testnets, forks and custom tokens).I compared Family (via
/api/prices-proxy), CoW and the Aave oracle across every reserve underlying and aToken on the CoW chains, plus the swap token list:Testing
tsc --noEmitandpnpm lintpass.After merge
Remove
FAMILY_API_KEYandFAMILY_API_URLfrom the Vercel project env.