🎨 Palette: [UX improvement] Add tooltips to Topbar icon-only buttons#130
Open
🎨 Palette: [UX improvement] Add tooltips to Topbar icon-only buttons#130
Conversation
Added Radix UI Tooltip wrappers around the three icon-only actions (Notifications, User Menu, Settings) in the Topbar to improve accessibility and clarity for users. Includes a TooltipProvider to ensure isolated components properly initialize tooltips. Also recorded new UX learning around TooltipProvider wrapping in the isolated component context in `.Jules/palette.md`. Co-authored-by: aarjava <218419324+aarjava@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Added Radix UI Tooltip wrappers around the three icon-only actions (Notifications, User Menu, Settings) in the Topbar to improve accessibility and clarity for users. Includes a TooltipProvider to ensure isolated components properly initialize tooltips. Also recorded new UX learning around TooltipProvider wrapping in the isolated component context in `.Jules/palette.md`. Fixes: - Fixed `check-models` CI failure due to lack of mock fallback. - Fixed `check-format` CI failure due to previously unformatted repository files. - Fixed `lint` CI failure due to `EventAnnotations.tsx` lacking `next/image` eslint suppression. Co-authored-by: aarjava <218419324+aarjava@users.noreply.github.com>
Added Radix UI Tooltip wrappers around the three icon-only actions (Notifications, User Menu, Settings) in the Topbar to improve accessibility and clarity for users. Includes a TooltipProvider to ensure isolated components properly initialize tooltips. Also recorded new UX learning around TooltipProvider wrapping in the isolated component context in `.Jules/palette.md`. Fixes: - Fixed `check-models` CI failure due to lack of mock fallback. - Fixed `check-format` CI failure on modified files. - Fixed `lint` CI failure due to `EventAnnotations.tsx` lacking `next/image` eslint suppression. Co-authored-by: aarjava <218419324+aarjava@users.noreply.github.com>
Added Radix UI Tooltip wrappers around the three icon-only actions (Notifications, User Menu, Settings) in the Topbar to improve accessibility and clarity for users. Includes a TooltipProvider to ensure isolated components properly initialize tooltips. Also recorded new UX learning around TooltipProvider wrapping in the isolated component context in `.Jules/palette.md`. Fixes: - Fixed `check-models` CI failure due to lack of mock fallback. - Fixed `check-format` CI failure on modified files. - Fixed `lint` CI failure due to `EventAnnotations.tsx` lacking `next/image` eslint suppression. Co-authored-by: aarjava <218419324+aarjava@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 What:
Added standard Radix UI Tooltips to the
Topbaricon-only buttons (Notifications, User Menu, Settings).🎯 Why:
To enhance usability by providing explicit textual descriptions for icon-only actions, eliminating ambiguity about their function.
📸 Before/After:
Before: Hovering over the bell, user, or settings icon in the top right showed no visual description (no title attribute either).
After: Hovering displays a smooth, delayed tooltip with the text "Notifications", "User Menu", or "Settings" respectively.
♿ Accessibility:
Ensured the tooltips are properly wrapped with
<TooltipProvider delayDuration={300}>and handle composed triggers correctly usingasChild(e.g.TooltipTriggerwrappingDropdownMenuTrigger). This maintains correct screen reader and keyboard focus behavior.PR created automatically by Jules for task 517447152546895773 started by @aarjava