Skip to content

Conversation

@a5chin
Copy link
Owner

@a5chin a5chin commented Jan 16, 2026

User description

Type of Change

  • Hotfix
  • Bug Fix
  • Dependency Update
  • Feature
  • Refactor
  • CI/CD
  • Documentation

Related Issues

Breaking Changes

  • No breaking changes
  • API signature changed
  • Configuration changed
  • Behavior changed
  • Dependencies changed
  • Features removed

Checklist

  • Dependencies added/updated
  • New environment variables
  • Performance impact assessed
  • Security implications reviewed
  • Deployment notes

Additional Context


PR Type

Bug fix, Enhancement


Description

  • Update SQLFluff VS Code extension ID.

  • Consolidate global VS Code editor settings.

  • Adjust devcontainer cache path.

  • Update documentation for devcontainer.


Diagram Walkthrough

flowchart LR
  A["Old SQLFluff Extension (dorzey)"] --> B["Update Extension ID"]
  B --> C["New SQLFluff Extension (sqlfluff)"]
  D["Scattered VS Code Settings"] --> E["Consolidate Global Settings"]
  C -- "Configures" --> E
Loading

File Walkthrough

Relevant files
Configuration changes
devcontainer.json
Update SQLFluff extension and devcontainer cache path       

.devcontainer/devcontainer.json

  • Replaced the old dorzey.vscode-sqlfluff extension with
    sqlfluff.vscode-sqlfluff.
  • Updated the updateContentCommand to use /home/vscode/.cache for
    consistency.
+2/-2     
cspell.json
Remove old SQLFluff author from cspell dictionary               

.vscode/cspell.json

  • Removed dorzey from the cspell dictionary, as the old SQLFluff
    extension author is no longer relevant.
+0/-1     
extensions.json
Update recommended SQLFluff VS Code extension                       

.vscode/extensions.json

  • Replaced the deprecated dorzey.vscode-sqlfluff with the official
    sqlfluff.vscode-sqlfluff in recommended extensions.
+1/-1     
settings.json
Consolidate editor settings and update SQL formatter         

.vscode/settings.json

  • Added global editor.autoIndent, editor.formatOnSave, and
    editor.insertSpaces settings.
  • Removed redundant editor settings from various language-specific
    sections (e.g., [dockercompose], [python], [yaml]).
  • Changed the editor.defaultFormatter for [sql] files to
    sqlfluff.vscode-sqlfluff.
  • Added editor.tabSize: 4 for [dockerfile] configurations.
+5/-26   
Documentation
uv.md
Update devcontainer documentation for SQLFluff extension 

docs/configurations/uv.md

  • Updated the example devcontainer.json configuration to reflect the new
    sqlfluff.vscode-sqlfluff extension ID.
+1/-1     

@a5chin a5chin self-assigned this Jan 16, 2026
@github-actions github-actions bot added documentation Improvements or additions to documentation fix labels Jan 16, 2026
@a5chin
Copy link
Owner Author

a5chin commented Jan 16, 2026

/review

@github-actions
Copy link
Contributor

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

User Assumption

The updateContentCommand hardcodes the user vscode for chown operations. While this is often the default user in dev containers, it's worth validating that the remoteUser variable is never expected to be different from vscode in this environment. If remoteUser could vary, using ${remoteUser} might be more robust.

"updateContentCommand": "sudo chown -R vscode /home/vscode/.cache /home/vscode/.ssh ${containerWorkspaceFolder}/.venv",

@a5chin
Copy link
Owner Author

a5chin commented Jan 16, 2026

/improve

@a5chin a5chin merged commit d160068 into main Jan 17, 2026
3 checks passed
@a5chin a5chin deleted the fix/sqlfluff-extension branch January 17, 2026 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation fix Review effort 1/5

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants