Skip to content

feat: Database forward compatibility: make owner field optional #812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sokoliva merged 7 commits into from
Mar 12, 2026
Merged

feat: Database forward compatibility: make owner field optional #812

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
e24fa5d
feat: update owner column to be nullable in tasks and push notificati…
sokoliva Mar 11, 2026
955aaab
feat: update owner column to be nullable in tasks and push notificati…
sokoliva Mar 11, 2026
7d809f8
Merge branch 'owner-optional' of https://github.com/sokoliva/a2a-pyth…
sokoliva Mar 11, 2026
723b8ed
Merge branch '1.0-dev' into owner-optional
sokoliva Mar 11, 2026
07655fd
Merge branch '1.0-dev' into owner-optional
sokoliva Mar 11, 2026
e8bffc6
Merge branch '1.0-dev' into owner-optional
sokoliva Mar 12, 2026
edac569
Merge branch '1.0-dev' into owner-optional
sokoliva Mar 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/a2a/a2a_db_cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ def create_parser() -> argparse.ArgumentParser:
parser.add_argument(
'--add_columns_owner_last_updated-default-owner',
dest='owner',
help="Value for the 'owner' column (used in specific migrations). If not set defaults to 'unknown'",
help="Value for the 'owner' column (used in specific migrations). If not set defaults to 'legacy_v03_no_user_info'",
)
_add_shared_args(parser)

Expand Down
4 changes: 2 additions & 2 deletions src/a2a/migrations/versions/6419d2d130f6_add_columns_owner_last_updated.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ def upgrade() -> None:
)

if table_exists(tasks_table):
add_column(tasks_table, 'owner', False, sa.String(255), owner)
add_column(tasks_table, 'owner', True, sa.String(255), owner)
add_column(tasks_table, 'last_updated', True, sa.DateTime())
add_index(
tasks_table,
Expand All @@ -63,7 +63,7 @@ def upgrade() -> None:
add_column(
push_notification_configs_table,
'owner',
False,
True,
sa.String(255),
owner,
)
Expand Down
4 changes: 2 additions & 2 deletions src/a2a/server/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ class TaskMixin:
kind: Mapped[str] = mapped_column(
String(16), nullable=False, default='task'
)
owner: Mapped[str] = mapped_column(String(255), nullable=False)
owner: Mapped[str] = mapped_column(String(255), nullable=True)
last_updated: Mapped[datetime | None] = mapped_column(
DateTime, nullable=True
)
Expand Down Expand Up @@ -145,7 +145,7 @@ class PushNotificationConfigMixin:
task_id: Mapped[str] = mapped_column(String(36), primary_key=True)
config_id: Mapped[str] = mapped_column(String(255), primary_key=True)
config_data: Mapped[bytes] = mapped_column(LargeBinary, nullable=False)
owner: Mapped[str] = mapped_column(String(255), nullable=False, index=True)
owner: Mapped[str] = mapped_column(String(255), nullable=True, index=True)
protocol_version: Mapped[str | None] = mapped_column(
String(16), nullable=True
)
Expand Down
Loading