Repository navigation
fix(grpc): avoid NPE when listTasks is called without a tenant - #1240
Merged
Merged
Conversation
Emryswu
force-pushed
the
fix/list-tasks-null-tenant
branch
from
October 21, 2026 12:40
aa163a9 to
c899da6
Compare
ehsavoie
requested changes
Oct 22, 2026
Convert an empty protobuf tenant back to null so that a null tenant survives a toProto/fromProto round trip.
ehsavoie
approved these changes
Oct 23, 2026
Collaborator
|
Thanks @Emryswu |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calling JSON-RPC
listTaskswithout a tenant throws an NPE before the request is sent: the MapStruct-generatedListTasksParamsMapperImpl.toProtocallssetTenant(null)on the protobuf builder. This happens with bothListTasksParams.builder().build()andnew ListTasksParams().The fix adds the same
conditionExpressionnull check already used for the other nullable fields inListTasksParamsMapper, and fortenantin the neighboring request mappers (TaskQueryParamsMapper,TaskIdParamsMapper, etc.). Non-null tenants are still mapped as before.REST and gRPC are not affected: both build
ListTasksRequestmanually and already guard the tenant.Tests cover the default builder, the no-arg constructor and a non-null tenant, both at the mapper level and through
JSONRPCTransport(checking the actual wire request). All 585 tests in the affected modules pass. The changed files pass strict Checkstyle; the 478 pre-existing violations on main are unchanged.Related to #1207