Skip to content

chore: enforce no-floating-promises in core/task/ #253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
0xMink wants to merge 1 commit into
base: chore/no-floating-promises-activate
Choose a base branch
from
Open

chore: enforce no-floating-promises in core/task/ #253

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 19 additions & 19 deletions src/core/task/Task.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -524,7 +524,7 @@ export class Task extends EventEmitter<TaskEvents> implements TaskLike {
this.messageQueueStateChangedHandler = () => {
this.emit(RooCodeEventName.TaskUserMessage, this.taskId)
this.emit(RooCodeEventName.QueuedMessagesUpdated, this.taskId, this.messageQueueService.messages)
this.providerRef.deref()?.postStateToWebviewWithoutTaskHistory()
void this.providerRef.deref()?.postStateToWebviewWithoutTaskHistory()
}

this.messageQueueService.on("stateChanged", this.messageQueueStateChangedHandler)
Expand Down Expand Up @@ -569,9 +569,9 @@ export class Task extends EventEmitter<TaskEvents> implements TaskLike {
if (startTask) {
this._started = true
if (task || images) {
this.startTask(task, images)
void this.startTask(task, images)
} else if (historyItem) {
this.resumeTaskFromHistory()
void this.resumeTaskFromHistory()
} else {
throw new Error("Either historyItem or task/images must be provided")
}
Expand Down Expand Up @@ -1153,7 +1153,7 @@ export class Task extends EventEmitter<TaskEvents> implements TaskLike {
// data or one whole message at a time so ignore partial for
// saves, and only post parts of partial message instead of
// whole array in new listener.
this.updateClineMessage(lastMessage)
void this.updateClineMessage(lastMessage)
// console.log("Task#ask: current ask promise was ignored (#1)")
throw new AskIgnoredError("updating existing partial")
} else {
Expand Down Expand Up @@ -1191,7 +1191,7 @@ export class Task extends EventEmitter<TaskEvents> implements TaskLike {
lastMessage.progressStatus = progressStatus
lastMessage.isProtected = isProtected
await this.saveClineMessages()
this.updateClineMessage(lastMessage)
void this.updateClineMessage(lastMessage)
} else {
// This is a new and complete message, so add it like normal.
this.askResponse = undefined
Expand Down Expand Up @@ -1253,7 +1253,7 @@ export class Task extends EventEmitter<TaskEvents> implements TaskLike {
if (message) {
this.interactiveAsk = message
this.emit(RooCodeEventName.TaskInteractive, this.taskId)
provider?.postMessageToWebview({ type: "interactionRequired" })
void provider?.postMessageToWebview({ type: "interactionRequired" })
}
}, statusMutationTimeout),
)
Expand Down Expand Up @@ -1636,7 +1636,7 @@ export class Task extends EventEmitter<TaskEvents> implements TaskLike {
lastMessage.images = images
lastMessage.partial = partial
lastMessage.progressStatus = progressStatus
this.updateClineMessage(lastMessage)
void this.updateClineMessage(lastMessage)
} else {
// This is a new partial message, so add it with partial state.
const sayTs = Date.now()
Expand Down Expand Up @@ -1675,7 +1675,7 @@ export class Task extends EventEmitter<TaskEvents> implements TaskLike {
await this.saveClineMessages()

// More performant than an entire `postStateToWebview`.
this.updateClineMessage(lastMessage)
void this.updateClineMessage(lastMessage)
} else {
// This is a new and complete message, so add it like normal.
const sayTs = Date.now()
Expand Down Expand Up @@ -1784,7 +1784,7 @@ export class Task extends EventEmitter<TaskEvents> implements TaskLike {
const { task, images } = this.metadata

if (task || images) {
this.startTask(task ?? undefined, images ?? undefined)
void this.startTask(task ?? undefined, images ?? undefined)
}
}

Expand Down Expand Up @@ -2325,7 +2325,7 @@ export class Task extends EventEmitter<TaskEvents> implements TaskLike {

private async initiateTaskLoop(userContent: Anthropic.Messages.ContentBlockParam[]): Promise<void> {
// Kicks off the checkpoints initialization process in the background.
getCheckpointService(this)
void getCheckpointService(this)

let nextUserContent = userContent
let includeFileDetails = true
Expand Down Expand Up @@ -2768,7 +2768,7 @@ export class Task extends EventEmitter<TaskEvents> implements TaskLike {
// Add to content and present
this.assistantMessageContent.push(partialToolUse)
this.userMessageContentReady = false
presentAssistantMessage(this)
void presentAssistantMessage(this)
} else if (event.type === "tool_call_delta") {
// Process chunk using streaming JSON parser
const partialToolUse = NativeToolCallParser.processStreamingChunk(
Expand All @@ -2787,7 +2787,7 @@ export class Task extends EventEmitter<TaskEvents> implements TaskLike {
this.assistantMessageContent[toolUseIndex] = partialToolUse

// Present updated tool use
presentAssistantMessage(this)
void presentAssistantMessage(this)
}
}
} else if (event.type === "tool_call_end") {
Expand All @@ -2813,7 +2813,7 @@ export class Task extends EventEmitter<TaskEvents> implements TaskLike {
this.userMessageContentReady = false

// Present the finalized tool call
presentAssistantMessage(this)
void presentAssistantMessage(this)
} else if (toolUseIndex !== undefined) {
// finalizeStreamingToolCall returned null (malformed JSON or missing args)
// Mark the tool as non-partial so it's presented as complete, but execution
Expand All @@ -2832,7 +2832,7 @@ export class Task extends EventEmitter<TaskEvents> implements TaskLike {
this.userMessageContentReady = false

// Present the tool call - validation will handle missing params
presentAssistantMessage(this)
void presentAssistantMessage(this)
}
}
}
Expand Down Expand Up @@ -2865,7 +2865,7 @@ export class Task extends EventEmitter<TaskEvents> implements TaskLike {

// Present the tool call to user - presentAssistantMessage will execute
// tools sequentially and accumulate all results in userMessageContent
presentAssistantMessage(this)
void presentAssistantMessage(this)
break
}
case "text": {
Expand All @@ -2884,7 +2884,7 @@ export class Task extends EventEmitter<TaskEvents> implements TaskLike {
})
this.userMessageContentReady = false
}
presentAssistantMessage(this)
void presentAssistantMessage(this)
break
}
}
Expand Down Expand Up @@ -3232,7 +3232,7 @@ export class Task extends EventEmitter<TaskEvents> implements TaskLike {
this.userMessageContentReady = false

// Present the finalized tool call
presentAssistantMessage(this)
void presentAssistantMessage(this)
} else if (toolUseIndex !== undefined) {
// finalizeStreamingToolCall returned null (malformed JSON or missing args)
// We still need to mark the tool as non-partial so it gets executed
Expand All @@ -3251,7 +3251,7 @@ export class Task extends EventEmitter<TaskEvents> implements TaskLike {
this.userMessageContentReady = false

// Present the tool call - validation will handle missing params
presentAssistantMessage(this)
void presentAssistantMessage(this)
}
}
}
Expand Down Expand Up @@ -3450,7 +3450,7 @@ export class Task extends EventEmitter<TaskEvents> implements TaskLike {
// If there is content to update then it will complete and
// update `this.userMessageContentReady` to true, which we
// `pWaitFor` before making the next request.
presentAssistantMessage(this)
void presentAssistantMessage(this)
}

if (hasTextContent || hasToolUses) {
Expand Down
12 changes: 6 additions & 6 deletions src/core/task/__tests__/Task.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1391,7 +1391,7 @@ describe("Cline", () => {
]

// Call submitUserMessage
task.submitUserMessage("test message", ["image1.png"])
await task.submitUserMessage("test message", ["image1.png"])

// Verify handleWebviewAskResponse was called directly (not webview)
expect(handleResponseSpy).toHaveBeenCalledWith("messageResponse", "test message", ["image1.png"])
Expand All @@ -1411,13 +1411,13 @@ describe("Cline", () => {
const handleResponseSpy = vi.spyOn(task, "handleWebviewAskResponse")

// Call with empty text and no images
task.submitUserMessage("", [])
await task.submitUserMessage("", [])

// Should not call handleWebviewAskResponse for empty messages
expect(handleResponseSpy).not.toHaveBeenCalled()

// Call with whitespace only
task.submitUserMessage(" ", [])
await task.submitUserMessage(" ", [])
expect(handleResponseSpy).not.toHaveBeenCalled()
})

Expand All @@ -1434,7 +1434,7 @@ describe("Cline", () => {

// Test with no messages (new task scenario)
task.clineMessages = []
task.submitUserMessage("new task", ["image1.png"])
await task.submitUserMessage("new task", ["image1.png"])

expect(handleResponseSpy).toHaveBeenCalledWith("messageResponse", "new task", ["image1.png"])

Expand All @@ -1450,7 +1450,7 @@ describe("Cline", () => {
text: "Initial message",
},
]
task.submitUserMessage("follow-up message", ["image2.png"])
await task.submitUserMessage("follow-up message", ["image2.png"])

expect(handleResponseSpy).toHaveBeenCalledWith("messageResponse", "follow-up message", ["image2.png"])
})
Expand All @@ -1477,7 +1477,7 @@ describe("Cline", () => {
const consoleErrorSpy = vi.spyOn(console, "error").mockImplementation(() => {})

// Should log error but not throw
task.submitUserMessage("test message")
await task.submitUserMessage("test message")

expect(consoleErrorSpy).toHaveBeenCalledWith("[Task#submitUserMessage] Provider reference lost")
expect(handleResponseSpy).not.toHaveBeenCalled()
Expand Down
2 changes: 1 addition & 1 deletion src/eslint.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ export default [
{
// Ratchet: enforce no-floating-promises directory by directory. Each
// directory is added here once its floating promises are resolved.
files: ["activate/**/*.ts"],
files: ["activate/**/*.ts", "core/task/**/*.ts"],
languageOptions: {
parserOptions: {
project: true,
Expand Down
Loading