Skip to content

[Chore] Isolate multi-root e2e coverage from the #204 fix#228

Draft
roomote[bot] wants to merge 2 commits into
roomote/repro-204-zoocode-e2efrom
roomote/repro-204-zoocode-e2e-followup
Draft

[Chore] Isolate multi-root e2e coverage from the #204 fix#228
roomote[bot] wants to merge 2 commits into
roomote/repro-204-zoocode-e2efrom
roomote/repro-204-zoocode-e2e-followup

Conversation

@roomote
Copy link
Copy Markdown
Contributor

@roomote roomote Bot commented May 21, 2026

Opened on behalf of Elliott de Launay. View the task or mention @roomote for follow-up asks.

What problem this solves

Resolves a problem where the #204 product fix and the VS Code extension-host regression harness were bundled into one review, which made the issue-closing change wait on fixture churn and e2e hardening work.

Why this change was made

This follow-up PR keeps the apps/vscode-e2e fixture, runner, and multi-root workspace test changes separate from the core workspace-path fix in #225. It also makes the default mocked CI path provision the multi-root workspace when the full suite runs unfiltered, so the new regression test exercises the same route that broke e2e-mock.

User impact

No direct user-visible behavior change. The multi-root extension-host regression coverage is easier to review and iterate on without widening the main #204 fix PR.

Related PRs

  • #225 - product fix for multi-root workspace path handling

@roomote roomote Bot added the roomote:auto-resolve-conflicts Allow Roomote to auto-resolve merge conflicts for this PR label May 21, 2026
@roomote
Copy link
Copy Markdown
Contributor Author

roomote Bot commented May 21, 2026

0 issues outstanding. See task

  • apps/vscode-e2e/src/runTest.ts now provisions the multi-root workspace for the default unfiltered mock-suite path as well as targeted multi-root runs, so the new suite no longer falls back to a single-root workspace in e2e-mock.
  • apps/vscode-e2e/src/runTest.ts now enables the two-root workspace for every unfiltered test:ci:mock run, and e2e-mock is red in src/suite/tools/execute-command.test.ts because those suites still assume the default single-root workspace. — resolved on the rebased head 430d19c09634cb51a28a1810fc22b786ab210784; local pnpm --filter @roo-code/vscode-e2e test:ci:mock passes and the fresh GitHub e2e-mock rerun is green.
  • platform-unit-test (windows-latest) was still pending after the 10-minute watch cap, so this sync review could not confirm the latest update is green on that lane yet. — resolved after rebasing onto #225; both platform-unit-test (ubuntu-latest) and platform-unit-test (windows-latest) are green on 430d19c09634cb51a28a1810fc22b786ab210784.

Comment thread apps/vscode-e2e/src/runTest.ts
@codecov
Copy link
Copy Markdown

codecov Bot commented May 21, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@roomote
Copy link
Copy Markdown
Contributor Author

roomote Bot commented May 21, 2026

Rebased and force-pushed 430d19c09 on #228.

What changed:

  • rebased roomote/repro-204-zoocode-e2e-followup onto the latest #225 base commit d4df00b6e, so the follow-up PR now carries the current Windows-path fixes from the product branch
  • kept the #228 diff itself unchanged: the branch still only contains the multi-root e2e fixture and runner follow-up under apps/vscode-e2e

Validation:

  • pnpm --filter @roo-code/vscode-e2e test:ci:mock
  • pnpm --dir apps/web-roo-code test

Visual proof: not applicable for this change because it only rebases the e2e/harness follow-up branch.

Final CI state on 430d19c09: e2e-mock, Analyze, check-translations, compile, knip, CodeQL, codecov/patch, platform-unit-test (ubuntu-latest), and platform-unit-test (windows-latest) are all green.

Comment thread apps/vscode-e2e/src/runTest.ts
@roomote roomote Bot force-pushed the roomote/repro-204-zoocode-e2e-followup branch from 9bf3bb5 to 430d19c Compare May 21, 2026 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

roomote:auto-resolve-conflicts Allow Roomote to auto-resolve merge conflicts for this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant