[Chore] Isolate multi-root e2e coverage from the #204 fix#228
Draft
roomote[bot] wants to merge 2 commits into
Draft
[Chore] Isolate multi-root e2e coverage from the #204 fix#228roomote[bot] wants to merge 2 commits into
roomote[bot] wants to merge 2 commits into
Conversation
Contributor
Author
|
0 issues outstanding. See task
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
Author
|
Rebased and force-pushed 430d19c09 on What changed:
Validation:
Visual proof: not applicable for this change because it only rebases the e2e/harness follow-up branch. Final CI state on |
9bf3bb5 to
430d19c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem this solves
Resolves a problem where the
#204product fix and the VS Code extension-host regression harness were bundled into one review, which made the issue-closing change wait on fixture churn and e2e hardening work.Why this change was made
This follow-up PR keeps the
apps/vscode-e2efixture, runner, and multi-root workspace test changes separate from the core workspace-path fix in #225. It also makes the default mocked CI path provision the multi-root workspace when the full suite runs unfiltered, so the new regression test exercises the same route that brokee2e-mock.User impact
No direct user-visible behavior change. The multi-root extension-host regression coverage is easier to review and iterate on without widening the main
#204fix PR.Related PRs