Skip to content

test(readFileTool): add comprehensive test coverage for ReadFileTool #222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
proyectoauraorg wants to merge 4 commits into
base: main
Choose a base branch
from
Open

test(readFileTool): add comprehensive test coverage for ReadFileTool #222

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ab3d116
test(readFileTool): add comprehensive test coverage for readFileTool
proyectoauraorg May 20, 2026
72e891b
fix(readFileTool): fix legacy format detection and test mocks
proyectoauraorg May 21, 2026
973e53f
test(readFile): restore console.warn spy in afterEach to prevent leakage
proyectoauraorg May 21, 2026
7b97253
test(readFileTool): fix check-types TS2352 on console.warn restore cast
proyectoauraorg May 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion packages/types/src/tool-params.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,10 @@ export type ReadFileToolParams = ReadFileParams | LegacyReadFileParams
* Type guard to check if params are in legacy format.
*/
export function isLegacyReadFileParams(params: ReadFileToolParams): params is LegacyReadFileParams {
return "_legacyFormat" in params && params._legacyFormat === true
// Detect explicit flag (new code path) or bare `files` array (real legacy chat data)
const hasLegacyFlag = "_legacyFormat" in params && params._legacyFormat === true
const hasFilesArray = "files" in params && Array.isArray((params as unknown as Record<string, unknown>).files)
return hasLegacyFlag || hasFilesArray
}

export interface Coordinate {
Expand Down
Loading
Loading