Skip to content

refactor: remove stale organizationMcps from MarketplaceManager and related components#196

Closed
proyectoauraorg wants to merge 3 commits into
Zoo-Code-Org:mainfrom
proyectoauraorg:refactor/62-remove-stale-organizationMcps
Closed

refactor: remove stale organizationMcps from MarketplaceManager and related components#196
proyectoauraorg wants to merge 3 commits into
Zoo-Code-Org:mainfrom
proyectoauraorg:refactor/62-remove-stale-organizationMcps

Conversation

@proyectoauraorg
Copy link
Copy Markdown
Contributor

Summary

Remove all stale organizationMcps references from the VSCode extension codebase.

Changes

This PR removes the deprecated organizationMcps field and all related logic from the following files:

  • MarketplaceManager.ts: Removed getOrganizationMcpId() method and organization MCP ID lookup logic from getMcpId() and toggleEnableMcp(). Added early return in toggleEnableMcp() if MCP is not in local registry.
  • ClineProvider.ts: Removed organizationMcpIds and organizationMcpServers fields from State type and their initialization from organization McpMarketplaceItem responses.
  • vscode-extension-host.ts: Removed organizationMcps from provider state initialization.
  • MarketplaceViewStateManager.ts: Removed organizationMcpIds and organizationMcpServers from initializeState() return.
  • MarketplaceListView.tsx: Removed organizationMcpServers and organizationMcpIds from MarketplaceViewState interface and their use in the getDisplayedMarketplaceServers() memo.
  • useStateManager.ts: Removed organizationMcpServers and organizationMcpIds from LocalMarketplaceState interface and convertToDisplayState() logic.

Test Cleanup

  • MarketplaceManager.spec.ts: Removed 5 tests for deleted methods (getOrganizationMcpId, toggleEnableMcp organization not-installed logic, isOrganizationMcp).
  • MarketplaceListView.spec.tsx: Updated mock state to remove organizationMcpServers and organizationMcpIds fields.

Verification

  • grep -r organizationMcps returns zero results
  • npm run compile succeeds
  • npx vitest run __tests__/marketplace/ passes
  • npx eslint / npx prettier --check pass

Closes #62

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 19, 2026

Warning

Rate limit exceeded

@proyectoauraorg has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 43 minutes and 38 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 02c81c6d-b942-4a3b-8023-c44bb559269e

📥 Commits

Reviewing files that changed from the base of the PR and between 7de61e6 and e3147f8.

📒 Files selected for processing (10)
  • .gitignore
  • CONTRIBUTIONS.md
  • packages/types/src/vscode-extension-host.ts
  • src/core/webview/ClineProvider.ts
  • src/services/marketplace/MarketplaceManager.ts
  • src/services/marketplace/__tests__/MarketplaceManager.spec.ts
  • webview-ui/src/components/marketplace/MarketplaceListView.tsx
  • webview-ui/src/components/marketplace/MarketplaceViewStateManager.ts
  • webview-ui/src/components/marketplace/__tests__/MarketplaceListView.spec.tsx
  • webview-ui/src/components/marketplace/useStateManager.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

…cronización

- Traducir todos los títulos, secciones y descripciones al español
- Agregar sección de Estado de Sincronización con tabla de branches
- Actualizar commit de referencia a 7de61e6
- Actualizar fecha y hora de última sincronización
…elated components

- Remove organizationMcps field from MarketplaceManager class and all CRUD methods (add, get, remove, clear)
- Remove organizationMcps from MarketplaceView interface and MarketplaceViewStateManager
- Remove organizationMcps from vscode-extension-host ConfigurationRequest interface
- Remove organization Mcps tab rendering from MarketplaceListView
- Remove organizationMcps from useStateManager hook
- Remove organization Mcps lifecycle from ClineProvider (onNewPrompt)
- Clean up test files: remove obsolete organization Mcps tests

Closes Zoo-Code-Org#62
@proyectoauraorg proyectoauraorg force-pushed the refactor/62-remove-stale-organizationMcps branch from e2f12d4 to e3147f8 Compare May 19, 2026 20:31
@codecov
Copy link
Copy Markdown

codecov Bot commented May 19, 2026

Codecov Report

❌ Patch coverage is 90.90909% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/core/webview/ClineProvider.ts 0.00% 1 Missing ⚠️
src/services/marketplace/MarketplaceManager.ts 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@proyectoauraorg proyectoauraorg deleted the refactor/62-remove-stale-organizationMcps branch May 20, 2026 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Follow up bundled marketplace cleanup for stale organizationMcps contract

1 participant