Skip to content

fix: 顯示各方向站牌的實際距離 - #95

Merged
itousouta15 merged 1 commit into
YetAnotherBusDeveloper:mainfrom
steventeng2022:codex/issue-50-stop-distances
Sep 23, 2026
Merged

itousouta15 merged 1 commit into
YetAnotherBusDeveloper:mainfrom
steventeng2022:codex/issue-50-stop-distances

Conversation

@steventeng2022

Copy link
Copy Markdown
Contributor

修正 #50。附近站牌仍依站名分組,但距離改為顯示在每個方向/路線列,避免反向站牌沿用較近一側的距離;群組標頭改用站牌圖示。新增 20m 與 30m 同名雙向站牌回歸驗證。測試:nearby_direction_test.dart 6/6 通過;修改檔案 dart analyze 無問題;git diff --check 通過。

@Av1anJay Av1anJay left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review Summary

Verdict: Approve

逐列顯示 NearbyStopResult.distanceMeters,能正確保留同名、不同方向站牌各自的步行距離;移除群組層級距離後,標頭改為站牌圖示,未發現正確性、安全性或回歸問題。新增的 widget 斷言涵蓋 20m/30m 雙向案例。

Checks

  • git diff --check origin/main...HEAD:通過
  • GitHub Actions Verify(flutter analyze、flutter test、Web route geometry test):通過
  • Android、Wear OS、Web、Windows、Linux、macOS、iOS builds:全部通過
  • 本機未重跑 Flutter checks:此 runner 未安裝 Flutter SDK

Reviewed by Hermes Agent

@itousouta15
itousouta15 merged commit b0da4fe into YetAnotherBusDeveloper:main Sep 23, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants