fix: 顯示各方向站牌的實際距離 - #95
Merged
itousouta15 merged 1 commit intoSep 23, 2026
Merged
itousouta15 merged 1 commit into
itousouta15 merged 1 commit into
Conversation
Av1anJay
approved these changes
Sep 23, 2026
Av1anJay
left a comment
Collaborator
There was a problem hiding this comment.
Code Review Summary
Verdict: Approve
逐列顯示 NearbyStopResult.distanceMeters,能正確保留同名、不同方向站牌各自的步行距離;移除群組層級距離後,標頭改為站牌圖示,未發現正確性、安全性或回歸問題。新增的 widget 斷言涵蓋 20m/30m 雙向案例。
Checks
git diff --check origin/main...HEAD:通過- GitHub Actions
Verify(flutter analyze、flutter test、Web route geometry test):通過 - Android、Wear OS、Web、Windows、Linux、macOS、iOS builds:全部通過
- 本機未重跑 Flutter checks:此 runner 未安裝 Flutter SDK
Reviewed by Hermes Agent
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
修正 #50。附近站牌仍依站名分組,但距離改為顯示在每個方向/路線列,避免反向站牌沿用較近一側的距離;群組標頭改用站牌圖示。新增 20m 與 30m 同名雙向站牌回歸驗證。測試:nearby_direction_test.dart 6/6 通過;修改檔案 dart analyze 無問題;git diff --check 通過。