This repository was archived by the owner on Jul 28, 2021. It is now read-only.
Ecmascript20#32
Open
trullock wants to merge 3 commits intoYUICompressor-NET:masterfrom
MyUNiDAYS:ecmascript20
Open
Ecmascript20#32trullock wants to merge 3 commits intoYUICompressor-NET:masterfrom MyUNiDAYS:ecmascript20
trullock wants to merge 3 commits intoYUICompressor-NET:masterfrom
MyUNiDAYS:ecmascript20
Conversation
Author
|
I see the other PRs have .net version upgrades and pushback on wanting netstandard support. I'm happy to help do this Shall we discuss that on #22 and decide what we want? |
Collaborator
|
@trullock Why was the net45 upgrade necessary for this PR? |
Author
|
because Ecmascript.Net 2.0 which contains the bugfix has been updated to 45 |
Member
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #29 by updating EcmaScript.NET reference
Had to update to Net4.5
I've had to drop CLS compliance because EcmaScript.NET now isnt CLS compliant under Net4.5.
I'd like to see this not be a problem for a 3.0.0.0 (maybe pre-release) version. I'll help get a new version of EcmaScript.NET CLS compliant in the background, but for now I'd really benefit from a YUIC that doesnt have this bug