Repository navigation
fix(bankfeeds): Describe V2 partial failures so apps can branch on error.type - #856
Draft
illanonline wants to merge 1 commit into
Draft
illanonline wants to merge 1 commit into
illanonline wants to merge 1 commit into
Conversation
…ror.type - Replace the four partial-failure types with five that each fix one recovery action: partial-failure-new-account-creation, partial-failure-new-account-existence-not-confirmed, partial-failure-previous-connection-deletion, partial-failure-connection-creation and partial-failure-connection-deletion - Add optional subtype, and accountId, accountName and connectionId on the error, so apps don't need to read title or detail - Item errors have no status property; the item's statusCode is the number (new ItemError schema) - Describe item-level internal-error (REJECTED, 500) and the 207 Multi-Status response Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
illanonline
force-pushed
the
FWFEED-44954-v2-partial-failure-contract
branch
from
October 20, 2026 06:34
a88104c to
b473683
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates
xero_bankfeeds_v2.yaml(Bank Feeds 2.0) so that partners can branch onerror.typeto handle a partial failure, without parsingtitleordetail. This PR stays draft until the matching API changes are ready to release.Partner-facing change
error.type:partial-failure-new-account-creation: don't resend. Connecterror.accountIdwith ExistingAccount.partial-failure-new-account-existence-not-confirmed(new, NewAccount): the account may have been created and its id is unknown. Check whether an account namederror.accountNameexists. Connect it with ExistingAccount if it does, otherwise resend the NewAccount item. If the app involves its user, it can send them back to account selection instead.partial-failure-*type: resend the same item.feed-already-connected-in-current-organisationon the recovery request means the earlier attempt was recorded.subtype(diagnostics only), andaccountId,accountNameandconnectionIdas fields on the error.statusproperty. The item'sstatusCodeis the number (newItemErrorschema).internal-errorandtoo-many-requests(REJECTED, 500), and the207 Multi-Statuswording.partial-failure-account-created-but-not-connectedpartial-failure-new-account-creationpartial-failure-migration-can-be-reattemptedpartial-failure-previous-connection-deletionpartial-failure-connection-created-but-not-recordedpartial-failure-connection-creationpartial-failure-delete-can-be-reattemptedpartial-failure-connection-deletionREJECTEDinternal-errorwith an account-may-exist hint indetailpartial-failure-new-account-existence-not-confirmed(new)Breaking change for Beta partners who match on the renamed types or the NewAccount
internal-errorhint. V2 is pre-GA.Based on the up-to-date
master(the earlier Bank Feeds V2 spec PR #849 is merged). Nomanifest.jsonchange is needed, and the version is bumped by semantic-release.