Skip to content

Fix stale archive reuse after unauthorized Xcode download - #487

Open
raisulchowdhury wants to merge 1 commit into
XcodesOrg:mainfrom
raisulchowdhury:fix/484-remove-invalid-download
Open

Fix stale archive reuse after unauthorized Xcode download#487
raisulchowdhury wants to merge 1 commit into
XcodesOrg:mainfrom
raisulchowdhury:fix/484-remove-invalid-download

Conversation

@raisulchowdhury

Copy link
Copy Markdown

Summary

  • remove an unauthorized response from the expected archive path when response validation fails
  • prevent a later invocation from reusing that invalid .xip
  • add a regression test covering the failed download followed by a successful retry

Fixes #484.

Testing

  • swift test --filter XcodesKitTests/test_DownloadOrUseExistingArchive_RedownloadsAfterUnauthorizedResponse
  • swift test (88 tests)

AI assistance

AI assistance was used to investigate and draft this change. I reviewed the complete diff and independently ran the targeted regression test and full test suite locally.

Copilot AI review requested due to automatic review settings July 29, 2026 21:38

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Partially downloaded/damaged Xcode archives aren't checked before moved to download location

2 participants