common/buf/writer.go: Fix buffered writes failing when payload exceeds remaining capacity - #6723
Merged
Merged
Conversation
Member
|
之前竟然没遇到问题 大概是没有协议握手包超过8192吧。。 |
Contributor
Author
This seems to come from #5020, which changed Buffer.Write to return ErrBufferFull on partial writes. |
Member
|
是的 我的意思是从那个PR迄今为止好像没遇到过有关报告 |
Contributor
Author
Yes, some of my users have reported this too. I also came across #5287 (comment) |
RPRX
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.