Merged
Conversation
Contributor
Author
|
https://github.com/getodk/javarosa/pull/781/changes which was released in Validate 1.20.0 re-established some checks for labels on internal choice lists that had accidentally been turned off in getodk/javarosa@847865c#diff-e045a71eed0a5d3fd849d1ca17f98246297bcae6d2d6b62203e17ec297365b03R348 It seems right to check them and in fact we have an issue for pyxform itself to do so (#534). I've quickly sanity checked that the Validate check still allows image-only options. |
yanokwa
approved these changes
Jan 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #799
Updates Validate to support the
intersectsfunction.Why is this the best possible solution? Were any other approaches considered?
This updates Validate to add an
intersectshandler so that it can recognize the function when used for validation. It follows the pattern for new functions.What are the regression risks?
It also updates JavaRosa so there's a chance an unrelated change could cause problems. The
intersectschange itself should be risk-free because it's additive.Does this change require updates to documentation? If so, please file an issue here and include the link below.
getodk/xforms-spec#332, getodk/docs#2021
Before submitting this PR, please make sure you have:
testspython -m unittestand verified all tests passruff format pyxform testsandruff check pyxform teststo lint code