798: incremental parameter for geotrace and geoshape#808
Merged
lognaturel merged 2 commits intoXLSForm:masterfrom Jan 8, 2026
Merged
798: incremental parameter for geotrace and geoshape#808lognaturel merged 2 commits intoXLSForm:masterfrom
lognaturel merged 2 commits intoXLSForm:masterfrom
Conversation
- used to signal that the control value should be validated on change (like keypress), rather than when the value is saved (like blur).
ad3800d to
51edc5a
Compare
lognaturel
approved these changes
Jan 8, 2026
Contributor
lognaturel
left a comment
There was a problem hiding this comment.
Thanks so much! I took the liberty of templating in values since that seemed like the clear intent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #798
Why is this the best possible solution? Were any other approaches considered?
Uses existing patterns for validation and error codes. Considered refactoring the geo parameters into a separate module but this PR is needed quickly. Other minor changes from the ticket:
trueare accepted (yes,true(), etc)incrementalparameter is there, but the value is not recognised. That seemed more helpful than ignoring the value since that'd be a likely scenario for a typo. Also an error is raised ifincrementalis specified for other question types that accept parameters, which is current behaviour. Otherwise it is ignored.What are the regression risks?
Should be none since it's a new parameter.
Does this change require updates to documentation? If so, please file an issue here and include the link below.
Spec and xlsform.org
Before submitting this PR, please make sure you have:
testspython -m unittestand verified all tests passruff format pyxform testsandruff check pyxform teststo lint code